Replace deprecated String.prototype.substr()

CommanderRoot · CommanderRoot · commit 181da1165e79 · 2022-04-17T00:36:28.000+02:00
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher &lt;rootcommander@gmail.com&gt;
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
@@ -331,13 +331,13 @@ if (typeof Sfjs === 'undefined' || typeof Sfjs.loadToolbar === 'undefined') {
 
                     /* prevent logging AJAX calls to static and inline files, like templates */
                     var path = url;
-                    if (url.substr(0, 1) === '/') {
+                    if (url.slice(0, 1) === '/') {
                         if (0 === url.indexOf('{{ request.basePath|e('js') }}')) {
-                            path = url.substr({{ request.basePath|length }});
+                            path = url.slice({{ request.basePath|length }});
                         }
                     }
                     else if (0 === url.indexOf('{{ (request.schemeAndHttpHost ~ request.basePath)|e('js') }}')) {
-                        path = url.substr({{ (request.schemeAndHttpHost ~ request.basePath)|length }});
+                        path = url.slice({{ (request.schemeAndHttpHost ~ request.basePath)|length }});
                     }
 
                     if (!path.match(new RegExp({{ excluded_ajax_paths|json_encode|raw }}))) {
diff --git a/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php b/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php
@@ -371,7 +371,7 @@ function xpathHasClass(className) {
         if (/\bsf-dump-toggle\b/.test(a.className)) {
             e.preventDefault();
             if (!toggle(a, isCtrlKey(e))) {
-                var r = doc.getElementById(a.getAttribute('href').substr(1)),
+                var r = doc.getElementById(a.getAttribute('href').slice(1)),
                     s = r.previousSibling,
                     f = r.parentNode,
                     t = a.parentNode;
@@ -438,7 +438,7 @@ function xpathHasClass(className) {
                 toggle(a);
             }
         } else if (/\bsf-dump-ref\b/.test(elt.className) && (a = elt.getAttribute('href'))) {
-            a = a.substr(1);
+            a = a.slice(1);
             elt.className += ' '+a;
 
             if (/[\[{]$/.test(elt.previousSibling.nodeValue)) {

Original file line number	Diff line number	Diff line change
`@@ -331,13 +331,13 @@ if (typeof Sfjs === 'undefined' \|\| typeof Sfjs.loadToolbar === 'undefined') {`
`331`	`331`
`332`	`332`	`/* prevent logging AJAX calls to static and inline files, like templates */`
`333`	`333`	`var path = url;`
`334`		`- if (url.substr(0, 1) === '/') {`
	`334`	`+ if (url.slice(0, 1) === '/') {`
`335`	`335`	`if (0 === url.indexOf('{{ request.basePath\|e('js') }}')) {`
`336`		`- path = url.substr({{ request.basePath\|length }});`
	`336`	`+ path = url.slice({{ request.basePath\|length }});`
`337`	`337`	`}`
`338`	`338`	`}`
`339`	`339`	`else if (0 === url.indexOf('{{ (request.schemeAndHttpHost ~ request.basePath)\|e('js') }}')) {`
`340`		`- path = url.substr({{ (request.schemeAndHttpHost ~ request.basePath)\|length }});`
	`340`	`+ path = url.slice({{ (request.schemeAndHttpHost ~ request.basePath)\|length }});`
`341`	`341`	`}`
`342`	`342`
`343`	`343`	`if (!path.match(new RegExp({{ excluded_ajax_paths\|json_encode\|raw }}))) {`