bug symfony#52488 [HttpKernel] Fix PHP deprecation (nicolas-grekas)

derrabus · derrabus · commit 2cd1e97e9d92 · 2023-11-07T21:39:43.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [HttpKernel] Fix PHP deprecation | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Commits ------- 9854346 [HttpKernel] Fix PHP deprecation
diff --git a/src/Symfony/Component/HttpKernel/DataCollector/LoggerDataCollector.php b/src/Symfony/Component/HttpKernel/DataCollector/LoggerDataCollector.php
@@ -224,7 +224,7 @@ private function getContainerDeprecationLogs(): array
 
     private function getContainerCompilerLogs(string $compilerLogsFilepath = null): array
     {
-        if (!is_file($compilerLogsFilepath)) {
+        if (!$compilerLogsFilepath || !is_file($compilerLogsFilepath)) {
             return [];
         }
 

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ private function getContainerDeprecationLogs(): array`
`224`	`224`
`225`	`225`	`private function getContainerCompilerLogs(string $compilerLogsFilepath = null): array`
`226`	`226`	`{`
`227`		`- if (!is_file($compilerLogsFilepath)) {`
	`227`	`+ if (!$compilerLogsFilepath \|\| !is_file($compilerLogsFilepath)) {`
`228`	`228`	`return [];`
`229`	`229`	`}`
`230`	`230`