Skip to content

Commit 37d0e25

Browse files
committed
Merge branch '5.4' into 6.3
* 5.4: skip tests that do not work with ICU 71.1
2 parents fcb11c7 + 0719891 commit 37d0e25

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTypeTest.php

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
use Symfony\Component\Form\ChoiceList\View\ChoiceView;
1515
use Symfony\Component\Form\FormError;
1616
use Symfony\Component\Form\FormInterface;
17+
use Symfony\Component\Intl\Intl;
1718
use Symfony\Component\Intl\Util\IntlTestHelper;
1819
use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;
1920

@@ -91,6 +92,10 @@ public function testSubmitFromSingleTextDateTime()
9192
// we test against "de_DE", so we need the full implementation
9293
IntlTestHelper::requireFullIntl($this, false);
9394

95+
if ('71.1' === Intl::getIcuVersion()) {
96+
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
97+
}
98+
9499
\Locale::setDefault('de_DE');
95100

96101
$form = $this->factory->create(static::TESTED_TYPE, null, [
@@ -113,6 +118,10 @@ public function testSubmitFromSingleTextDateTimeImmutable()
113118
// we test against "de_DE", so we need the full implementation
114119
IntlTestHelper::requireFullIntl($this, false);
115120

121+
if ('71.1' === Intl::getIcuVersion()) {
122+
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
123+
}
124+
116125
\Locale::setDefault('de_DE');
117126

118127
$form = $this->factory->create(static::TESTED_TYPE, null, [
@@ -136,6 +145,10 @@ public function testSubmitFromSingleTextString()
136145
// we test against "de_DE", so we need the full implementation
137146
IntlTestHelper::requireFullIntl($this, false);
138147

148+
if ('71.1' === Intl::getIcuVersion()) {
149+
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
150+
}
151+
139152
\Locale::setDefault('de_DE');
140153

141154
$form = $this->factory->create(static::TESTED_TYPE, null, [
@@ -158,6 +171,10 @@ public function testSubmitFromSingleTextTimestamp()
158171
// we test against "de_DE", so we need the full implementation
159172
IntlTestHelper::requireFullIntl($this, false);
160173

174+
if ('71.1' === Intl::getIcuVersion()) {
175+
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
176+
}
177+
161178
\Locale::setDefault('de_DE');
162179

163180
$form = $this->factory->create(static::TESTED_TYPE, null, [
@@ -182,6 +199,10 @@ public function testSubmitFromSingleTextRaw()
182199
// we test against "de_DE", so we need the full implementation
183200
IntlTestHelper::requireFullIntl($this, false);
184201

202+
if ('71.1' === Intl::getIcuVersion()) {
203+
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
204+
}
205+
185206
\Locale::setDefault('de_DE');
186207

187208
$form = $this->factory->create(static::TESTED_TYPE, null, [

0 commit comments

Comments
 (0)