bug symfony#48075 [Mailer] Stream timeout not detected fgets returns false (Sezil)

fabpot · fabpot · commit 538491bf8608 · 2022-11-04T07:30:41.000+01:00
This PR was submitted for the 5.4 branch but it was merged into the 4.4 branch instead. Discussion ---------- [Mailer] Stream timeout not detected fgets returns false symfony#48074 [Mailer] Stream timeout not detected due to checking only string result of function fgets | Q | A | ------------- | --- | Branch? | 6.2 for features / 4.4, 5.4, 6.0 or 6.1 for bug fixes  | Bug fix? | yes/no | New feature? | yes/no  | Deprecations? | yes/no  | Tickets | Fix #...  | License | MIT | Doc PR | symfony/symfony-docs#...   Commits ------- 486f2c5 [Mailer] Stream timeout not detected due to checking only string result of function fgets
diff --git a/src/Symfony/Component/Mailer/Transport/Smtp/Stream/AbstractStream.php b/src/Symfony/Component/Mailer/Transport/Smtp/Stream/AbstractStream.php
@@ -75,7 +75,7 @@ public function readLine(): string
         }
 
         $line = fgets($this->out);
-        if ('' === $line) {
+        if ('' === $line || false === $line) {
             $metas = stream_get_meta_data($this->out);
             if ($metas['timed_out']) {
                 throw new TransportException(sprintf('Connection to "%s" timed out.', $this->getReadConnectionDescription()));

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public function readLine(): string`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`$line = fgets($this->out);`
`78`		`- if ('' === $line) {`
	`78`	`+ if ('' === $line \|\| false === $line) {`
`79`	`79`	`$metas = stream_get_meta_data($this->out);`
`80`	`80`	`if ($metas['timed_out']) {`
`81`	`81`	`throw new TransportException(sprintf('Connection to "%s" timed out.', $this->getReadConnectionDescription()));`