bug symfony#32579 [Config] Do not use absolute path when computing the vendor freshness (lyrixx)

nicolas-grekas · nicolas-grekas · commit 54c77e6a6198 · 2019-07-18T08:47:54.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Config] Do not use absolute path when computing the vendor freshness | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | When one uses Docker with a different mounting point between CLI & FPM, the cache keeps regenerating because the ComposerResource class see a different path for each SAPI. For example `/home/app/app/vendor` vs `/var/www/app/vendor`. So if you hit FPM, then the CLI, then FPM, each time a new cache is generated. So the application is quite slow in dev env. And for people on MacOSX (with docker) is a big pain! And obvisouly, this never stabilizes ! This occurs a lot when you have a worker, that crash and reboot in the background, and you browse the web interface. Or when you have something that hit your API every X secondes, and you are working on a worker. Commits ------- 2d2e274 [Config] Do not use absolute path when computing the vendor freshness
diff --git a/src/Symfony/Component/Config/Resource/ComposerResource.php b/src/Symfony/Component/Config/Resource/ComposerResource.php
@@ -48,7 +48,7 @@ public function isFresh($timestamp)
     {
         self::refresh();
 
-        return self::$runtimeVendors === $this->vendors;
+        return array_values(self::$runtimeVendors) === array_values($this->vendors);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public function isFresh($timestamp)`
`48`	`48`	`{`
`49`	`49`	`self::refresh();`
`50`	`50`
`51`		`- return self::$runtimeVendors === $this->vendors;`
	`51`	`+ return array_values(self::$runtimeVendors) === array_values($this->vendors);`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`/**`