bug symfony#32170 [Security/Core] Don't use ParagonIE_Sodium_Compat (nicolas-grekas)

fabpot · fabpot · commit 675d463cf566 · 2019-06-25T15:14:38.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Security/Core] Don't use ParagonIE_Sodium_Compat | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This is dead code: https://github.com/paragonie/sodium_compat#features-excluded-from-this-polyfill Commits ------- 61ea53d [Security/Core] Don't use ParagonIE_Sodium_Compat
diff --git a/src/Symfony/Component/Security/Core/Encoder/Argon2iPasswordEncoder.php b/src/Symfony/Component/Security/Core/Encoder/Argon2iPasswordEncoder.php
@@ -26,10 +26,6 @@ public static function isSupported()
             return true;
         }
 
-        if (class_exists('ParagonIE_Sodium_Compat') && method_exists('ParagonIE_Sodium_Compat', 'crypto_pwhash_is_available')) {
-            return \ParagonIE_Sodium_Compat::crypto_pwhash_is_available();
-        }
-
         return \function_exists('sodium_crypto_pwhash_str') || \extension_loaded('libsodium');
     }
 

Original file line number	Diff line number	Diff line change
`@@ -26,10 +26,6 @@ public static function isSupported()`
`26`	`26`	`return true;`
`27`	`27`	`}`
`28`	`28`
`29`		`- if (class_exists('ParagonIE_Sodium_Compat') && method_exists('ParagonIE_Sodium_Compat', 'crypto_pwhash_is_available')) {`
`30`		`- return \ParagonIE_Sodium_Compat::crypto_pwhash_is_available();`
`31`		`- }`
`32`		`-`
`33`	`29`	`return \function_exists('sodium_crypto_pwhash_str') \|\| \extension_loaded('libsodium');`
`34`	`30`	`}`
`35`	`31`