minor symfony#32268 [FrameworkBundle] better message for disabled sessions (Tobion)

fabpot · fabpot · commit 6eeec6506ca0 · 2019-06-29T08:20:53.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] better message for disabled sessions | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | symfony#32215 | License | MIT | Doc PR | Use correct exception class and make the message consistent with all the other exception messages in the FrameworkExtension. Commits ------- b3e3247 [FrameworkBundle] better message for disabled sessions
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -234,7 +234,7 @@ public function load(array $configs, ContainerBuilder $container)
 
         if ($this->isConfigEnabled($container, $config['session'])) {
             if (!\extension_loaded('session')) {
-                throw new \LogicException('PHP extension "session" is required.');
+                throw new LogicException('Session support cannot be enabled as the session extension is not installed. See https://www.php.net/session.installation for instructions.');
             }
 
             $this->sessionConfigEnabled = true;

Original file line number	Diff line number	Diff line change
`@@ -234,7 +234,7 @@ public function load(array $configs, ContainerBuilder $container)`
`234`	`234`
`235`	`235`	`if ($this->isConfigEnabled($container, $config['session'])) {`
`236`	`236`	`if (!\extension_loaded('session')) {`
`237`		`- throw new \LogicException('PHP extension "session" is required.');`
	`237`	`+ throw new LogicException('Session support cannot be enabled as the session extension is not installed. See https://www.php.net/session.installation for instructions.');`
`238`	`238`	`}`
`239`	`239`
`240`	`240`	`$this->sessionConfigEnabled = true;`