minor symfony#31115 [Form] Workaround for \DateInterval::createFromDateString() (renanbr)

nicolas-grekas · nicolas-grekas · commit 81d11c3f2e70 · 2019-04-15T15:32:17.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Form] Workaround for \DateInterval::createFromDateString() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This patch makes test `Symfony\Component\Form\Tests\Extension\Core\Type\DateIntervalTypeTest::testSubmitNullUsesDateEmptyData()` pass in PHP 7.2.17 and 7.3.4 PHP bug reference : https://bugs.php.net/bug.php?id=77896 See also : https://3v4l.org/sQjh2 Commits ------- 54247ec Workaround for \DateInterval::createFromDateString()
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/DateIntervalTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/DateIntervalTypeTest.php
@@ -442,7 +442,7 @@ public function testSubmitNullUsesDateEmptyData($widget, $emptyData, $expectedDa
 
     public function provideEmptyData()
     {
-        $expectedData = \DateInterval::createFromDateString('6 years and 4 months');
+        $expectedData = new \DateInterval('P6Y4M');
 
         return [
             'Simple field' => ['single_text', 'P6Y4M0D', $expectedData],

Original file line number	Diff line number	Diff line change
`@@ -442,7 +442,7 @@ public function testSubmitNullUsesDateEmptyData($widget, $emptyData, $expectedDa`
`442`	`442`
`443`	`443`	`public function provideEmptyData()`
`444`	`444`	`{`
`445`		`- $expectedData = \DateInterval::createFromDateString('6 years and 4 months');`
	`445`	`+ $expectedData = new \DateInterval('P6Y4M');`
`446`	`446`
`447`	`447`	`return [`
`448`	`448`	`'Simple field' => ['single_text', 'P6Y4M0D', $expectedData],`