Passing null to Inline::parse is not allowed

GromNaN · GromNaN · commit 834e0ab6e219 · 2023-10-27T21:10:30.000+02:00
diff --git a/src/Symfony/Component/Yaml/Inline.php b/src/Symfony/Component/Yaml/Inline.php
@@ -55,7 +55,7 @@ public static function initialize(int $flags, int $parsedLineNumber = null, stri
      *
      * @throws ParseException
      */
-    public static function parse(string $value = null, int $flags = 0, array &$references = []): mixed
+    public static function parse(string $value, int $flags = 0, array &$references = []): mixed
     {
         self::initialize($flags);
 
diff --git a/src/Symfony/Component/Yaml/Tests/InlineTest.php b/src/Symfony/Component/Yaml/Tests/InlineTest.php
@@ -29,7 +29,7 @@ protected function setUp(): void
     /**
      * @dataProvider getTestsForParse
      */
-    public function testParse($yaml, $value, $flags = 0)
+    public function testParse(string $yaml, $value, $flags = 0)
     {
         $this->assertSame($value, Inline::parse($yaml, $flags), sprintf('::parse() converts an inline YAML to a PHP structure (%s)', $yaml));
     }

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public static function initialize(int $flags, int $parsedLineNumber = null, stri`
`55`	`55`	`*`
`56`	`56`	`* @throws ParseException`
`57`	`57`	`*/`
`58`		`- public static function parse(string $value = null, int $flags = 0, array &$references = []): mixed`
	`58`	`+ public static function parse(string $value, int $flags = 0, array &$references = []): mixed`
`59`	`59`	`{`
`60`	`60`	`self::initialize($flags);`
`61`	`61`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ protected function setUp(): void`
`29`	`29`	`/**`
`30`	`30`	`* @dataProvider getTestsForParse`
`31`	`31`	`*/`
`32`		`- public function testParse($yaml, $value, $flags = 0)`
	`32`	`+ public function testParse(string $yaml, $value, $flags = 0)`
`33`	`33`	`{`
`34`	`34`	`$this->assertSame($value, Inline::parse($yaml, $flags), sprintf('::parse() converts an inline YAML to a PHP structure (%s)', $yaml));`
`35`	`35`	`}`