Allow set 'None' on samesite cookie flag

markitosgv · web-flow · commit 8bac3d6fa319 · 2019-05-10T21:58:31.000+02:00
Allow set samesite cookie flag to 'None' value
diff --git a/src/Symfony/Component/HttpFoundation/Cookie.php b/src/Symfony/Component/HttpFoundation/Cookie.php
@@ -28,6 +28,7 @@ class Cookie
     private $raw;
     private $sameSite;
 
+    const SAMESITE_NONE = 'none';
     const SAMESITE_LAX = 'lax';
     const SAMESITE_STRICT = 'strict';
 
@@ -128,7 +129,7 @@ public function __construct($name, $value = null, $expire = 0, $path = '/', $dom
             $sameSite = strtolower($sameSite);
         }
 
-        if (!\in_array($sameSite, [self::SAMESITE_LAX, self::SAMESITE_STRICT, null], true)) {
+        if (!\in_array($sameSite, [self::SAMESITE_LAX, self::SAMESITE_STRICT, self::SAMESITE_NONE, null], true)) {
             throw new \InvalidArgumentException('The "sameSite" parameter value is not valid.');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ class Cookie`
`28`	`28`	`private $raw;`
`29`	`29`	`private $sameSite;`
`30`	`30`
	`31`	`+ const SAMESITE_NONE = 'none';`
`31`	`32`	`const SAMESITE_LAX = 'lax';`
`32`	`33`	`const SAMESITE_STRICT = 'strict';`
`33`	`34`
`@@ -128,7 +129,7 @@ public function __construct($name, $value = null, $expire = 0, $path = '/', $dom`
`128`	`129`	`$sameSite = strtolower($sameSite);`
`129`	`130`	`}`
`130`	`131`
`131`		`- if (!\in_array($sameSite, [self::SAMESITE_LAX, self::SAMESITE_STRICT, null], true)) {`
	`132`	`+ if (!\in_array($sameSite, [self::SAMESITE_LAX, self::SAMESITE_STRICT, self::SAMESITE_NONE, null], true)) {`
`132`	`133`	`throw new \InvalidArgumentException('The "sameSite" parameter value is not valid.');`
`133`	`134`	`}`
`134`	`135`