minor symfony#32672 [VarDumper] revert private properties handling (xabbuh)

nicolas-grekas · nicolas-grekas · commit 90acd03c133d · 2019-07-23T10:33:50.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] revert private properties handling | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 9bad905 revert private properties handling
diff --git a/src/Symfony/Component/VarDumper/Cloner/Stub.php b/src/Symfony/Component/VarDumper/Cloner/Stub.php
@@ -49,17 +49,11 @@ public function __sleep()
         $properties = [];
 
         if (!isset(self::$defaultProperties[$c = \get_class($this)])) {
-            $defaultProperties = get_class_vars($c);
+            self::$defaultProperties[$c] = get_class_vars($c);
 
-            foreach ((new \ReflectionClass($c))->getProperties(\ReflectionProperty::IS_PUBLIC) as $v) {
-                if ($v->isStatic()) {
-                    unset($defaultProperties[$v->name]);
-                } elseif (!isset($defaultProperties[$v->name])) {
-                    $defaultProperties[$v->name] = null;
-                }
+            foreach ((new \ReflectionClass($c))->getStaticProperties() as $k => $v) {
+                unset(self::$defaultProperties[$c][$k]);
             }
-
-            self::$defaultProperties[$c] = $defaultProperties;
         }
 
         foreach (self::$defaultProperties[$c] as $k => $v) {
