minor symfony#52798 Fix legacy class palceholder definitions for static analysis (ausi)

nicolas-grekas · nicolas-grekas · commit 914496290fc8 · 2023-11-29T15:34:14.000+01:00
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- Fix legacy class palceholder definitions for static analysis | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT In symfony#50392 the `UriSigner` class was moved from HttpKernel to HttpFoundation. The empty definition `class UriSigner {}` causes many issues with static analysis tools like PHPStan. As this code is wrapped in an `if (false)` changing it to `class UriSigner extends HttpFoundationUriSigner` should not cause any behavior change while fixing most static analysis issues. Commits ------- 0f230fe Fix legacy class palceholder definitions for static analysis
diff --git a/src/Symfony/Bundle/FrameworkBundle/Routing/AnnotatedRouteControllerLoader.php b/src/Symfony/Bundle/FrameworkBundle/Routing/AnnotatedRouteControllerLoader.php
@@ -19,7 +19,7 @@ class_exists(AttributeRouteControllerLoader::class);
     /**
      * @deprecated since Symfony 6.4, to be removed in 7.0, use {@link AttributeRouteControllerLoader} instead
      */
-    class AnnotatedRouteControllerLoader
+    class AnnotatedRouteControllerLoader extends AttributeRouteControllerLoader
     {
     }
 }
diff --git a/src/Symfony/Component/HttpKernel/Debug/FileLinkFormatter.php b/src/Symfony/Component/HttpKernel/Debug/FileLinkFormatter.php
@@ -25,7 +25,7 @@ class_alias(ErrorHandlerFileLinkFormatter::class, FileLinkFormatter::class);
     /**
      * @deprecated since Symfony 6.4, use FileLinkFormatter from the ErrorHandler component instead
      */
-    class FileLinkFormatter
+    class FileLinkFormatter extends ErrorHandlerFileLinkFormatter
     {
     }
 }
diff --git a/src/Symfony/Component/HttpKernel/UriSigner.php b/src/Symfony/Component/HttpKernel/UriSigner.php
@@ -21,7 +21,7 @@ class_exists(HttpFoundationUriSigner::class);
     /**
      * @deprecated since Symfony 6.4, to be removed in 7.0, use {@link HttpFoundationUriSigner} instead
      */
-    class UriSigner
+    class UriSigner extends HttpFoundationUriSigner
     {
     }
 }
diff --git a/src/Symfony/Component/Routing/Loader/AnnotationClassLoader.php b/src/Symfony/Component/Routing/Loader/AnnotationClassLoader.php
@@ -19,7 +19,7 @@ class_exists(AttributeClassLoader::class);
     /**
      * @deprecated since Symfony 6.4, to be removed in 7.0, use {@link AttributeClassLoader} instead
      */
-    class AnnotationClassLoader
+    abstract class AnnotationClassLoader extends AttributeClassLoader
     {
     }
 }
diff --git a/src/Symfony/Component/Routing/Loader/AnnotationDirectoryLoader.php b/src/Symfony/Component/Routing/Loader/AnnotationDirectoryLoader.php
@@ -19,7 +19,7 @@ class_exists(AttributeDirectoryLoader::class);
     /**
      * @deprecated since Symfony 6.4, to be removed in 7.0, use {@link AttributeDirectoryLoader} instead
      */
-    class AnnotationDirectoryLoader
+    class AnnotationDirectoryLoader extends AttributeDirectoryLoader
     {
     }
 }
diff --git a/src/Symfony/Component/Routing/Loader/AnnotationFileLoader.php b/src/Symfony/Component/Routing/Loader/AnnotationFileLoader.php
@@ -19,7 +19,7 @@ class_exists(AttributeFileLoader::class);
     /**
      * @deprecated since Symfony 6.4, to be removed in 7.0, use {@link AttributeFileLoader} instead
      */
-    class AnnotationFileLoader
+    class AnnotationFileLoader extends AttributeFileLoader
     {
     }
 }
diff --git a/src/Symfony/Component/Serializer/Mapping/Loader/AnnotationLoader.php b/src/Symfony/Component/Serializer/Mapping/Loader/AnnotationLoader.php
@@ -19,7 +19,7 @@ class_exists(AttributeLoader::class);
     /**
      * @deprecated since Symfony 6.4, to be removed in 7.0, use {@link AttributeLoader} instead
      */
-    class AnnotationLoader
+    class AnnotationLoader extends AttributeLoader
     {
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ class_exists(AttributeRouteControllerLoader::class);`
`19`	`19`	`/**`
`20`	`20`	`* @deprecated since Symfony 6.4, to be removed in 7.0, use {@link AttributeRouteControllerLoader} instead`
`21`	`21`	`*/`
`22`		`- class AnnotatedRouteControllerLoader`
	`22`	`+ class AnnotatedRouteControllerLoader extends AttributeRouteControllerLoader`
`23`	`23`	`{`
`24`	`24`	`}`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ class_alias(ErrorHandlerFileLinkFormatter::class, FileLinkFormatter::class);`
`25`	`25`	`/**`
`26`	`26`	`* @deprecated since Symfony 6.4, use FileLinkFormatter from the ErrorHandler component instead`
`27`	`27`	`*/`
`28`		`- class FileLinkFormatter`
	`28`	`+ class FileLinkFormatter extends ErrorHandlerFileLinkFormatter`
`29`	`29`	`{`
`30`	`30`	`}`
`31`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class_exists(HttpFoundationUriSigner::class);`
`21`	`21`	`/**`
`22`	`22`	`* @deprecated since Symfony 6.4, to be removed in 7.0, use {@link HttpFoundationUriSigner} instead`
`23`	`23`	`*/`
`24`		`- class UriSigner`
	`24`	`+ class UriSigner extends HttpFoundationUriSigner`
`25`	`25`	`{`
`26`	`26`	`}`
`27`	`27`	`}`