bug symfony#31076 [HttpKernel] Fixed LoggerDataCollector crashing on empty file (althaus)

nicolas-grekas · nicolas-grekas · commit 9483779f5ffb · 2019-04-11T13:43:56.000+02:00
This PR was submitted for the 4.2 branch but it was merged into the 3.4 branch instead (closes symfony#31076). Discussion ---------- [HttpKernel] Fixed LoggerDataCollector crashing on empty file | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#31050 | License | MIT This PR adds a check to the LoggerDataCollector if there's acutal some content in the log file. Commits ------- 291c73a Catch empty deprecation.log silently (fixes symfony#31050)
diff --git a/src/Symfony/Component/HttpKernel/DataCollector/LoggerDataCollector.php b/src/Symfony/Component/HttpKernel/DataCollector/LoggerDataCollector.php
@@ -126,9 +126,13 @@ private function getContainerDeprecationLogs()
             return [];
         }
 
+        if ('' === $logContent = trim(file_get_contents($file))) {
+            return [];
+        }
+
         $bootTime = filemtime($file);
         $logs = [];
-        foreach (unserialize(file_get_contents($file)) as $log) {
+        foreach (unserialize($logContent) as $log) {
             $log['context'] = ['exception' => new SilencedErrorContext($log['type'], $log['file'], $log['line'], $log['trace'], $log['count'])];
             $log['timestamp'] = $bootTime;
             $log['priority'] = 100;
