Skip to content

Commit 9bc8b39

Browse files
minor symfony#32249 [Validator] remove invalid test cases (xabbuh)
This PR was merged into the 3.4 branch. Discussion ---------- [Validator] remove invalid test cases | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Spotted while working on symfony#32179 for the Validator component. Using property paths for comparison when validating arrays simply does not work. Commits ------- d1261e7 remove invalid test cases
2 parents 3f53044 + d1261e7 commit 9bc8b39

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

src/Symfony/Component/Validator/Tests/Constraints/AbstractComparisonValidatorTestCase.php

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -148,20 +148,6 @@ public function testValidComparisonToPropertyPath($comparedValue)
148148
$this->assertNoViolation();
149149
}
150150

151-
/**
152-
* @dataProvider provideValidComparisonsToPropertyPath
153-
*/
154-
public function testValidComparisonToPropertyPathOnArray($comparedValue)
155-
{
156-
$constraint = $this->createConstraint(['propertyPath' => '[root][value]']);
157-
158-
$this->setObject(['root' => ['value' => 5]]);
159-
160-
$this->validator->validate($comparedValue, $constraint);
161-
162-
$this->assertNoViolation();
163-
}
164-
165151
public function testNoViolationOnNullObjectWithPropertyPath()
166152
{
167153
$constraint = $this->createConstraint(['propertyPath' => 'propertyPath']);

0 commit comments

Comments
 (0)