bug symfony#29764 [HttpFoundation] Check file exists before unlink (adam-mospan)

nicolas-grekas · nicolas-grekas · commit afb7bb5ddef8 · 2019-01-25T12:01:14.000+01:00
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes symfony#29764). Discussion ---------- [HttpFoundation] Check file exists before unlink Check file exists to prevent ErrorException | Q | A | ------------- | --- | Branch? | 2.6  | Bug fix? | yes | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | #...  | License | MIT | Doc PR | symfony/symfony-docs#...   Commits ------- 1954187 [HttpFoundation] Check file exists before unlink
diff --git a/src/Symfony/Component/HttpFoundation/BinaryFileResponse.php b/src/Symfony/Component/HttpFoundation/BinaryFileResponse.php
@@ -305,7 +305,7 @@ public function sendContent()
         fclose($out);
         fclose($file);
 
-        if ($this->deleteFileAfterSend) {
+        if ($this->deleteFileAfterSend && file_exists($this->file->getPathname())) {
             unlink($this->file->getPathname());
         }
 

Original file line number	Diff line number	Diff line change
`@@ -305,7 +305,7 @@ public function sendContent()`
`305`	`305`	`fclose($out);`
`306`	`306`	`fclose($file);`
`307`	`307`
`308`		`- if ($this->deleteFileAfterSend) {`
	`308`	`+ if ($this->deleteFileAfterSend && file_exists($this->file->getPathname())) {`
`309`	`309`	`unlink($this->file->getPathname());`
`310`	`310`	`}`
`311`	`311`