bug symfony#52626 [Serializer] Fix denormalizing date intervals having both weeks and days (oneNevan)

nicolas-grekas · nicolas-grekas · commit b2c68ceae25e · 2023-11-20T10:57:46.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Fix denormalizing date intervals having both weeks and days | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix symfony#47629 | License | MIT Added support for date periods having both W and D period designators combined together (which is valid duration for ISO 8601-2). Starting from PHP 8 this is supported by \DateTimeInterval, see https://bugs.php.net/bug.php?id=61366 for reference Commits ------- c88d49e [Serializer] Fix denormalizing date intervals having both weeks and days
diff --git a/src/Symfony/Component/Serializer/Normalizer/DateIntervalNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DateIntervalNormalizer.php
@@ -128,6 +128,10 @@ public function supportsDenormalization($data, string $type, string $format = nu
 
     private function isISO8601(string $string): bool
     {
+        if (\PHP_VERSION_ID >= 80000) {
+            return preg_match('/^[\-+]?P(?=\w*(?:\d|%\w))(?:\d+Y|%[yY]Y)?(?:\d+M|%[mM]M)?(?:\d+W|%[wW]W)?(?:\d+D|%[dD]D)?(?:T(?:\d+H|[hH]H)?(?:\d+M|[iI]M)?(?:\d+S|[sS]S)?)?$/', $string);
+        }
+
         return preg_match('/^[\-+]?P(?=\w*(?:\d|%\w))(?:\d+Y|%[yY]Y)?(?:\d+M|%[mM]M)?(?:(?:\d+D|%[dD]D)|(?:\d+W|%[wW]W))?(?:T(?:\d+H|[hH]H)?(?:\d+M|[iI]M)?(?:\d+S|[sS]S)?)?$/', $string);
     }
 }
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/DateIntervalNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/DateIntervalNormalizerTest.php
@@ -119,6 +119,21 @@ public function testDenormalizeIntervalsWithOmittedPartsBeingZero()
         $this->assertDateIntervalEquals($this->getInterval('P0Y0M0DT12H34M0S'), $normalizer->denormalize('PT12H34M', \DateInterval::class));
     }
 
+    /**
+     * Since PHP 8.0 DateInterval::construct supports periods containing both D and W period designators.
+     *
+     * @requires PHP 8
+     */
+    public function testDenormalizeIntervalWithBothWeeksAndDays()
+    {
+        $input = 'P1W1D';
+        $interval = $this->normalizer->denormalize($input, \DateInterval::class, null, [
+            DateIntervalNormalizer::FORMAT_KEY => '%rP%yY%mM%wW%dDT%hH%iM%sS',
+        ]);
+        $this->assertDateIntervalEquals($this->getInterval($input), $interval);
+        $this->assertSame(8, $interval->d);
+    }
+
     public function testDenormalizeExpectsString()
     {
         $this->expectException(NotNormalizableValueException::class);

Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,10 @@ public function supportsDenormalization($data, string $type, string $format = nu`
`128`	`128`
`129`	`129`	`private function isISO8601(string $string): bool`
`130`	`130`	`{`
	`131`	`+ if (\PHP_VERSION_ID >= 80000) {`
	`132`	`+ return preg_match('/^[\-+]?P(?=\w*(?:\d\|%\w))(?:\d+Y\|%[yY]Y)?(?:\d+M\|%[mM]M)?(?:\d+W\|%[wW]W)?(?:\d+D\|%[dD]D)?(?:T(?:\d+H\|[hH]H)?(?:\d+M\|[iI]M)?(?:\d+S\|[sS]S)?)?$/', $string);`
	`133`	`+ }`
	`134`	`+`
`131`	`135`	`return preg_match('/^[\-+]?P(?=\w*(?:\d\|%\w))(?:\d+Y\|%[yY]Y)?(?:\d+M\|%[mM]M)?(?:(?:\d+D\|%[dD]D)\|(?:\d+W\|%[wW]W))?(?:T(?:\d+H\|[hH]H)?(?:\d+M\|[iI]M)?(?:\d+S\|[sS]S)?)?$/', $string);`
`132`	`136`	`}`
`133`	`137`	`}`