bug symfony#52332 [Yaml] Fix deprecated passing null to trim() (javaDeveloperKid)

fabpot · fabpot · commit b2e372d2200b · 2023-10-28T16:28:00.000-07:00
This PR was merged into the 5.4 branch. Discussion ---------- [Yaml] Fix deprecated passing null to trim() | Q | A | ------------- | --- | Branch? |5.4  | Bug fix? | yes | New feature? | no  | Deprecations? |no  | Issues | Closes symfony#52326  | License | MIT Commits ------- 54fc3c5 Fix passing null to trim()
diff --git a/src/Symfony/Component/Yaml/Inline.php b/src/Symfony/Component/Yaml/Inline.php
@@ -60,6 +60,10 @@ public static function initialize(int $flags, int $parsedLineNumber = null, stri
      */
     public static function parse(string $value = null, int $flags = 0, array &$references = [])
     {
+        if (null === $value) {
+            return '';
+        }
+
         self::initialize($flags);
 
         $value = trim($value);
diff --git a/src/Symfony/Component/Yaml/Tests/InlineTest.php b/src/Symfony/Component/Yaml/Tests/InlineTest.php
@@ -288,6 +288,7 @@ public static function getTestsForParse()
     {
         return [
             ['', ''],
+            [null, ''],
             ['null', null],
             ['false', false],
             ['true', true],

Original file line number	Diff line number	Diff line change
`@@ -288,6 +288,7 @@ public static function getTestsForParse()`
`288`	`288`	`{`
`289`	`289`	`return [`
`290`	`290`	`['', ''],`
	`291`	`+ [null, ''],`
`291`	`292`	`['null', null],`
`292`	`293`	`['false', false],`
`293`	`294`	`['true', true],`