minor symfony#35472 [Security] Improved error message when no supported user provider is found (wouterj)

nicolas-grekas · nicolas-grekas · commit b90664ba185d · 2020-01-27T10:47:05.000+01:00
This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead. Discussion ---------- [Security] Improved error message when no supported user provider is found | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix symfony#35435 | License | MIT | Doc PR | - Commits ------- 6b2db6d Improved error message when no supported user provider is found
diff --git a/src/Symfony/Component/Security/Core/User/ChainUserProvider.php b/src/Symfony/Component/Security/Core/User/ChainUserProvider.php
@@ -91,7 +91,7 @@ public function refreshUser(UserInterface $user)
             $e->setUsername($user->getUsername());
             throw $e;
         } else {
-            throw new UnsupportedUserException(sprintf('The account "%s" is not supported.', \get_class($user)));
+            throw new UnsupportedUserException(sprintf('There is no user provider for user "%s". Shouldn\'t the "supportsClass()" method of your user provider return true for this classname?', \get_class($user)));
         }
     }
 
diff --git a/src/Symfony/Component/Security/Http/Firewall/ContextListener.php b/src/Symfony/Component/Security/Http/Firewall/ContextListener.php
@@ -238,7 +238,7 @@ protected function refreshUser(TokenInterface $token)
             return null;
         }
 
-        throw new \RuntimeException(sprintf('There is no user provider for user "%s".', $userClass));
+        throw new \RuntimeException(sprintf('There is no user provider for user "%s". Shouldn\'t the "supportsClass()" method of your user provider return true for this classname?', $userClass));
     }
 
     private function safelyUnserialize($serializedToken)
diff --git a/src/Symfony/Component/Security/Http/RememberMe/AbstractRememberMeServices.php b/src/Symfony/Component/Security/Http/RememberMe/AbstractRememberMeServices.php
@@ -239,7 +239,7 @@ final protected function getUserProvider($class)
             }
         }
 
-        throw new UnsupportedUserException(sprintf('There is no user provider that supports class "%s".', $class));
+        throw new UnsupportedUserException(sprintf('There is no user provider for user "%s". Shouldn\'t the "supportsClass()" method of your user provider return true for this classname?', $class));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ public function refreshUser(UserInterface $user)`
`91`	`91`	`$e->setUsername($user->getUsername());`
`92`	`92`	`throw $e;`
`93`	`93`	`} else {`
`94`		`- throw new UnsupportedUserException(sprintf('The account "%s" is not supported.', \get_class($user)));`
	`94`	`+ throw new UnsupportedUserException(sprintf('There is no user provider for user "%s". Shouldn\'t the "supportsClass()" method of your user provider return true for this classname?', \get_class($user)));`
`95`	`95`	`}`
`96`	`96`	`}`
`97`	`97`
Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ protected function refreshUser(TokenInterface $token)`
`238`	`238`	`return null;`
`239`	`239`	`}`
`240`	`240`
`241`		`- throw new \RuntimeException(sprintf('There is no user provider for user "%s".', $userClass));`
	`241`	`+ throw new \RuntimeException(sprintf('There is no user provider for user "%s". Shouldn\'t the "supportsClass()" method of your user provider return true for this classname?', $userClass));`
`242`	`242`	`}`
`243`	`243`
`244`	`244`	`private function safelyUnserialize($serializedToken)`
Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ final protected function getUserProvider($class)`
`239`	`239`	`}`
`240`	`240`	`}`
`241`	`241`
`242`		`- throw new UnsupportedUserException(sprintf('There is no user provider that supports class "%s".', $class));`
	`242`	`+ throw new UnsupportedUserException(sprintf('There is no user provider for user "%s". Shouldn\'t the "supportsClass()" method of your user provider return true for this classname?', $class));`
`243`	`243`	`}`
`244`	`244`
`245`	`245`	`/**`