bug symfony#52727 [String] Fix Inflector for 'icon' (podhy)

nicolas-grekas · nicolas-grekas · commit dcbfcb4743b9 · 2023-11-26T14:43:54.000+01:00
This PR was submitted for the 7.1 branch but it was merged into the 5.4 branch instead. Discussion ---------- [String] Fix Inflector for 'icon' | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Hello, this PR fixes problem when inflecting `icon` word into `icons`. Currently it returns wrong result `ica` Please make someone review because I'm not 100% sure if this is the right way how to fix it. Thank you. Btw: older versions are also affected and it should be possible to merge it there Commits ------- 4f620a1 [String] Fix Inflector for 'icon'
diff --git a/src/Symfony/Component/String/Inflector/EnglishInflector.php b/src/Symfony/Component/String/Inflector/EnglishInflector.php
@@ -253,6 +253,9 @@ final class EnglishInflector implements InflectorInterface
         // seasons (season), treasons (treason), poisons (poison), lessons (lesson)
         ['nos', 3, true, true, 'sons'],
 
+        // icons (icon)
+        ['noc', 3, true, true, 'cons'],
+
         // bacteria (bacterium), criteria (criterion), phenomena (phenomenon)
         ['no', 2, true, true, 'a'],
 
diff --git a/src/Symfony/Component/String/Tests/Inflector/EnglishInflectorTest.php b/src/Symfony/Component/String/Tests/Inflector/EnglishInflectorTest.php
@@ -295,6 +295,7 @@ public static function pluralizeProvider()
             ['tree', 'trees'],
             ['waltz', 'waltzes'],
             ['wife', 'wives'],
+            ['icon', 'icons'],
 
             // test casing: if the first letter was uppercase, it should remain so
             ['Man', 'Men'],
