[Bridge\ProxyManager] isProxyCandidate() does not take into account interfaces

andrerom · andrerom · commit e3739b1289fe · 2019-05-20T13:02:42.000+02:00
When using factories it's common best practice to use interface as class name, especially in cases
where you know impl can differ. Before this fix ProxyManager did not allow these to be lazy.

In our case this has lead several to hard to debug issues on classes we need to mark as lazyi
and often a need to add lazy on decorators if there are any or other workarounds.
As we have had this issue, and still have on both 2.8 and 3.4 this is opened against 2.8.
diff --git a/src/Symfony/Bridge/ProxyManager/LazyProxy/PhpDumper/ProxyDumper.php b/src/Symfony/Bridge/ProxyManager/LazyProxy/PhpDumper/ProxyDumper.php
@@ -47,7 +47,7 @@ public function __construct($salt = '')
      */
     public function isProxyCandidate(Definition $definition)
     {
-        return $definition->isLazy() && ($class = $definition->getClass()) && class_exists($class);
+        return $definition->isLazy() && ($class = $definition->getClass()) && (class_exists($class) || interface_exists($class));
     }
 
     /**
diff --git a/src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/PhpDumper/ProxyDumperTest.php b/src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/PhpDumper/ProxyDumperTest.php
@@ -15,6 +15,7 @@
 use Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\ProxyDumper;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
+use Symfony\Component\DependencyInjection\LazyProxy\PhpDumper\DumperInterface;
 
 /**
  * Tests for {@see \Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\ProxyDumper}.
@@ -137,6 +138,7 @@ public function getProxyCandidates()
         $definitions = [
             [new Definition(__CLASS__), true],
             [new Definition('stdClass'), true],
+            [new Definition(DumperInterface::class), true],
             [new Definition(uniqid('foo', true)), false],
             [new Definition(), false],
         ];

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public function __construct($salt = '')`
`47`	`47`	`*/`
`48`	`48`	`public function isProxyCandidate(Definition $definition)`
`49`	`49`	`{`
`50`		`- return $definition->isLazy() && ($class = $definition->getClass()) && class_exists($class);`
	`50`	`+ return $definition->isLazy() && ($class = $definition->getClass()) && (class_exists($class) \|\| interface_exists($class));`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`/**`