minor symfony#30464 [Debug][DebugClassLoader] Detect annotations before blank docblock lines on final and internal methods (fancyweb)

nicolas-grekas · nicolas-grekas · commit e9c8e19f4672 · 2019-03-07T09:07:26.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- [Debug][DebugClassLoader] Detect annotations before blank docblock lines on final and internal methods | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - @xabbuh Follow up of symfony#30437 Commits ------- e97ea77 [Debug][DebugClassLoader] Detect annotations before blank docblock lines on final and internal methods
diff --git a/src/Symfony/Component/Debug/DebugClassLoader.php b/src/Symfony/Component/Debug/DebugClassLoader.php
@@ -307,7 +307,7 @@ public function checkAnnotations(\ReflectionClass $refl, $class)
             }
 
             foreach (['final', 'internal'] as $annotation) {
-                if (false !== \strpos($doc, $annotation) && preg_match('#\n\s+\* @'.$annotation.'(?:( .+?)\.?)?\r?\n\s+\*(?: @|/$)#s', $doc, $notice)) {
+                if (false !== \strpos($doc, $annotation) && preg_match('#\n\s+\* @'.$annotation.'(?:( .+?)\.?)?\r?\n\s+\*(?: @|/$|\r?\n)#s', $doc, $notice)) {
                     $message = isset($notice[1]) ? preg_replace('#\.?\r?\n( \*)? *(?= |\r?\n|$)#', '', $notice[1]) : '';
                     self::${$annotation.'Methods'}[$class][$method->name] = [$class, $message];
                 }
diff --git a/src/Symfony/Component/Debug/Tests/Fixtures/FinalMethod.php b/src/Symfony/Component/Debug/Tests/Fixtures/FinalMethod.php
@@ -13,6 +13,8 @@ public function finalMethod()
 
     /**
      * @final
+     *
+     * @return int
      */
     public function finalMethod2()
     {

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ public function checkAnnotations(\ReflectionClass $refl, $class)`
`307`	`307`	`}`
`308`	`308`
`309`	`309`	`foreach (['final', 'internal'] as $annotation) {`
`310`		`- if (false !== \strpos($doc, $annotation) && preg_match('#\n\s+\* @'.$annotation.'(?:( .+?)\.?)?\r?\n\s+\*(?: @\|/$)#s', $doc, $notice)) {`
	`310`	`+ if (false !== \strpos($doc, $annotation) && preg_match('#\n\s+\* @'.$annotation.'(?:( .+?)\.?)?\r?\n\s+\*(?: @\|/$\|\r?\n)#s', $doc, $notice)) {`
`311`	`311`	`$message = isset($notice[1]) ? preg_replace('#\.?\r?\n( \)? (?= \|\r?\n\|$)#', '', $notice[1]) : '';`
`312`	`312`	`self::${$annotation.'Methods'}[$class][$method->name] = [$class, $message];`
`313`	`313`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,8 @@ public function finalMethod()`
`13`	`13`
`14`	`14`	`/**`
`15`	`15`	`* @final`
	`16`	`+ *`
	`17`	`+ * @return int`
`16`	`18`	`*/`
`17`	`19`	`public function finalMethod2()`
`18`	`20`	`{`