minor symfony#52377 [SecurityBundle] Remove method for Sf 5.4 compatibility (OskarStark)

chalasr · chalasr · commit f1bfd880eb33 · 2023-11-07T03:06:18.000+01:00
This PR was merged into the 7.0 branch. Discussion ---------- [SecurityBundle] Remove method for Sf 5.4 compatibility | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | -- | License | MIT I am not sure if this is correct what I am doing here 🤔 If this is wrong, just close the PR, thanks Commits ------- afbdb63 Remove method for Sf 5.4 compatibility
diff --git a/src/Symfony/Component/Ldap/Security/LdapAuthenticator.php b/src/Symfony/Component/Ldap/Security/LdapAuthenticator.php
@@ -65,14 +65,6 @@ public function authenticate(Request $request): Passport
         return $passport;
     }
 
-    /**
-     * @internal
-     */
-    public function createAuthenticatedToken(PassportInterface $passport, string $firewallName): TokenInterface
-    {
-        throw new \BadMethodCallException(sprintf('The "%s()" method cannot be called.', __METHOD__));
-    }
-
     public function createToken(Passport $passport, string $firewallName): TokenInterface
     {
         return $this->authenticator->createToken($passport, $firewallName);
diff --git a/src/Symfony/Component/Security/Http/Tests/Fixtures/DummyAuthenticator.php b/src/Symfony/Component/Security/Http/Tests/Fixtures/DummyAuthenticator.php
@@ -46,8 +46,4 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
     {
         return null;
     }
-
-    public function createAuthenticatedToken(PassportInterface $passport, string $firewallName): TokenInterface
-    {
-    }
 }

Original file line number	Diff line number	Diff line change
`@@ -65,14 +65,6 @@ public function authenticate(Request $request): Passport`
`65`	`65`	`return $passport;`
`66`	`66`	`}`
`67`	`67`
`68`		`- /**`
`69`		`- * @internal`
`70`		`- */`
`71`		`- public function createAuthenticatedToken(PassportInterface $passport, string $firewallName): TokenInterface`
`72`		`- {`
`73`		`- throw new \BadMethodCallException(sprintf('The "%s()" method cannot be called.', __METHOD__));`
`74`		`- }`
`75`		`-`
`76`	`68`	`public function createToken(Passport $passport, string $firewallName): TokenInterface`
`77`	`69`	`{`
`78`	`70`	`return $this->authenticator->createToken($passport, $firewallName);`
Original file line number	Diff line number	Diff line change
`@@ -46,8 +46,4 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio`
`46`	`46`	`{`
`47`	`47`	`return null;`
`48`	`48`	`}`
`49`		`-`
`50`		`- public function createAuthenticatedToken(PassportInterface $passport, string $firewallName): TokenInterface`
`51`		`- {`
`52`		`- }`
`53`	`49`	`}`