minor symfony#52418 [HttpClient] add native argument for the test server working directory (xabbuh)

nicolas-grekas · nicolas-grekas · commit fa590af43d29 · 2023-11-02T10:14:30.000+01:00
This PR was merged into the 7.0 branch. Discussion ---------- [HttpClient] add native argument for the test server working directory | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- b9b5a62 add native argument for the test server working directory
diff --git a/src/Symfony/Contracts/HttpClient/Test/TestHttpServer.php b/src/Symfony/Contracts/HttpClient/Test/TestHttpServer.php
@@ -18,12 +18,9 @@ class TestHttpServer
 {
     private static array $process = [];
 
-    /**
-     * @param string|null $workingDirectory
-     */
-    public static function start(int $port = 8057/* , string $workingDirectory = null */): Process
+    public static function start(int $port = 8057, string $workingDirectory = null): Process
     {
-        $workingDirectory = \func_get_args()[1] ?? __DIR__.'/Fixtures/web';
+        $workingDirectory ??= __DIR__.'/Fixtures/web';
 
         if (isset(self::$process[$port])) {
             self::$process[$port]->stop();

Original file line number	Diff line number	Diff line change
`@@ -18,12 +18,9 @@ class TestHttpServer`
`18`	`18`	`{`
`19`	`19`	`private static array $process = [];`
`20`	`20`
`21`		`- /**`
`22`		`- * @param string\|null $workingDirectory`
`23`		`- */`
`24`		`- public static function start(int $port = 8057/* , string $workingDirectory = null */): Process`
	`21`	`+ public static function start(int $port = 8057, string $workingDirectory = null): Process`
`25`	`22`	`{`
`26`		`- $workingDirectory = \func_get_args()[1] ?? __DIR__.'/Fixtures/web';`
	`23`	`+ $workingDirectory ??= __DIR__.'/Fixtures/web';`
`27`	`24`
`28`	`25`	`if (isset(self::$process[$port])) {`
`29`	`26`	`self::$process[$port]->stop();`