chore: fix (*coderdtest.WorkspaceAgentWaiter).Wait() flake (coder#13451)

coadler · web-flow · commit e4ac69146849 · 2024-06-03T14:46:56.000-05:00
diff --git a/coderd/coderdtest/coderdtest.go b/coderd/coderdtest/coderdtest.go
@@ -1018,7 +1018,7 @@ func (w WorkspaceAgentWaiter) Wait() []codersdk.WorkspaceResource {
 	require.Eventually(w.t, func() bool {
 		var err error
 		workspace, err := w.client.Workspace(ctx, w.workspaceID)
-		if !assert.NoError(w.t, err) {
+		if err != nil {
 			return false
 		}
 		if workspace.LatestBuild.Job.CompletedAt == nil {

Original file line number	Diff line number	Diff line change
`@@ -1018,7 +1018,7 @@ func (w WorkspaceAgentWaiter) Wait() []codersdk.WorkspaceResource {`
`1018`	`1018`	`require.Eventually(w.t, func() bool {`
`1019`	`1019`	`var err error`
`1020`	`1020`	`workspace, err := w.client.Workspace(ctx, w.workspaceID)`
`1021`		`- if !assert.NoError(w.t, err) {`
	`1021`	`+ if err != nil {`
`1022`	`1022`	`return false`
`1023`	`1023`	`}`
`1024`	`1024`	`if workspace.LatestBuild.Job.CompletedAt == nil {`