Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cadence-workflow/cadence-java-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: cadence-workflow/cadence-java-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.x.x
Choose a head ref
  • 3 commits
  • 550 files changed
  • 1 contributor

Commits on Jun 12, 2025

  1. remove raw history (#1004)

    What changed?
    
    Remove raw history support in client
    
    Why?
    
    History is stored as Thrift encoded binary. Sending raw history in Thrift will no longer be supported in V4
    
    How did you test it?
    
    Unit Test
    shijiesheng committed Jun 12, 2025
    Configuration menu
    Copy the full SHA
    b8dc99e View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2025

  1. added WorkflowServiceGrpc and IWorkflowServiceV4 (#999)

    What changed?
    
    added client entities that maps 1:1 with thrift (generated from a generator)
    added BaseError, which is a catchall similar to TException.
    added mappers to transform Proto to client entities. (mostly copied from thrift mappers)
    added IWorkflowServiceV4 which is exactly same as IWorkflowService except for it's using the client entities.
    added WorkflowServiceGrpc that implements the V4 interface
    Plan
    
    new V4 interface with new entities < This PR
    replace all pointers to V4 in one go (Should be import change only)
    Why?
    
    Thrift deprecation work
    
    How did you test it?
    
    Unit Test on mappers from ClientObjects to ProtoObjects
    shijiesheng authored Jun 13, 2025
    Configuration menu
    Copy the full SHA
    aafd9dd View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2025

  1. remove unnecessary internal TasklistKind entity (#1010)

    What changed?
    
    replace internal TasklistKind entity with thrift one directly, which will be replaced with V4 entity eventually
    Why?
    
    TasklistKind is an internal entity introduced earlier. With V4, we already have this and thus do not need extra ones.
    shijiesheng authored Jun 26, 2025
    Configuration menu
    Copy the full SHA
    3609827 View commit details
    Browse the repository at this point in the history
Loading