link directly to the PR on github

jtarchie · jtarchie · commit 414e06d4db00 · 2016-03-31T08:41:14.000-06:00
diff --git a/assets/lib/common.rb b/assets/lib/common.rb
@@ -56,7 +56,7 @@ def sha
   end
 
   def url
-    @pr['url']
+    @pr['html_url']
   end
 
   private
diff --git a/assets/lib/in.rb b/assets/lib/in.rb
@@ -28,9 +28,9 @@ def ref
   system('git submodule update --init --recursive 1>&2')
   system("git fetch -q origin pull/#{id}/head:pr-#{id} 1>&2")
   system("git checkout pr-#{id} 1>&2")
-  system("git config --add pullrequest.url #{pr['url']} 1>&2")
+  system("git config --add pullrequest.url #{pr['html_url']} 1>&2")
   system("git config --add pullrequest.id #{pr['number']} 1>&2")
 end
 
 puts JSON.generate(version:  { ref: ref, pr: id.to_s },
-                   metadata: [{ name: 'url', value: pr['url'] }])
+                   metadata: [{ name: 'url', value: pr['html_url'] }])
diff --git a/spec/integration/in_spec.rb b/spec/integration/in_spec.rb
@@ -23,7 +23,7 @@ def commit(msg)
 
   before do
     proxy.stub('https://api.github.com:443/repos/jtarchie/test/pulls/1')
-         .and_return(json: { url: 'http://example.com', number: 1 })
+         .and_return(json: { html_url: 'http://example.com', number: 1 })
 
     git('init -q')
     @ref = commit('init')
diff --git a/spec/integration/out_spec.rb b/spec/integration/out_spec.rb
@@ -53,7 +53,7 @@ def request_body(method, url)
       git('config --add pullrequest.id 1')
       proxy.stub('https://api.github.com:443/repos/jtarchie/test/pulls/1')
            .and_return(json: {
-                         url: 'http://example.com',
+                         html_url: 'http://example.com',
                          number: 1,
                          head: { sha: 'abcdef' }
                        })
