feat: controls whether to automatically notify Watcher

nodece · nodece · commit 2ce07c29cd49 · 2020-04-18T15:35:35.000+08:00
diff --git a/src/coreEnforcer.ts b/src/coreEnforcer.ts
@@ -38,6 +38,7 @@ export class CoreEnforcer {
   private enabled: boolean;
   protected autoSave: boolean;
   protected autoBuildRoleLinks: boolean;
+  protected autoNotifyWatcher: boolean;
 
   public initialize(): void {
     this.rm = new DefaultRoleManager(10);
@@ -48,6 +49,7 @@ export class CoreEnforcer {
     this.enabled = true;
     this.autoSave = true;
     this.autoBuildRoleLinks = true;
+    this.autoNotifyWatcher = true;
   }
 
   /**
@@ -227,6 +229,14 @@ export class CoreEnforcer {
     this.autoSave = autoSave;
   }
 
+  /**
+   * enableAutoNotifyWatcher controls whether to save a policy rule automatically notify the Watcher when it is added or removed.
+   * @param enable whether to enable the AutoNotifyWatcher feature.
+   */
+  public enableAutoNotifyWatcher(enable: boolean): void {
+    this.autoNotifyWatcher = enable;
+  }
+
   /**
    * enableAutoBuildRoleLinks controls whether to save a policy rule
    * automatically to the adapter when it is added or removed.
diff --git a/src/internalEnforcer.ts b/src/internalEnforcer.ts
@@ -35,11 +35,11 @@ export class InternalEnforcer extends CoreEnforcer {
           throw e;
         }
       }
+    }
 
-      if (this.watcher) {
-        // error intentionally ignored
-        await this.watcher.update();
-      }
+    if (this.watcher && this.autoNotifyWatcher) {
+      // error intentionally ignored
+      await this.watcher.update();
     }
 
     return ruleAdded;
@@ -62,11 +62,11 @@ export class InternalEnforcer extends CoreEnforcer {
           throw e;
         }
       }
+    }
 
-      if (this.watcher) {
-        // error intentionally ignored
-        await this.watcher.update();
-      }
+    if (this.watcher && this.autoNotifyWatcher) {
+      // error intentionally ignored
+      await this.watcher.update();
     }
 
     return ruleRemoved;
@@ -89,11 +89,11 @@ export class InternalEnforcer extends CoreEnforcer {
           throw e;
         }
       }
+    }
 
-      if (this.watcher) {
-        // error intentionally ignored
-        await this.watcher.update();
-      }
+    if (this.watcher && this.autoNotifyWatcher) {
+      // error intentionally ignored
+      await this.watcher.update();
     }
 
     return ruleRemoved;

Original file line number	Diff line number	Diff line change
`@@ -35,11 +35,11 @@ export class InternalEnforcer extends CoreEnforcer {`
`35`	`35`	`throw e;`
`36`	`36`	`}`
`37`	`37`	`}`
	`38`	`+ }`
`38`	`39`
`39`		`- if (this.watcher) {`
`40`		`- // error intentionally ignored`
`41`		`- await this.watcher.update();`
`42`		`- }`
	`40`	`+ if (this.watcher && this.autoNotifyWatcher) {`
	`41`	`+ // error intentionally ignored`
	`42`	`+ await this.watcher.update();`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`return ruleAdded;`
`@@ -62,11 +62,11 @@ export class InternalEnforcer extends CoreEnforcer {`
`62`	`62`	`throw e;`
`63`	`63`	`}`
`64`	`64`	`}`
	`65`	`+ }`
`65`	`66`
`66`		`- if (this.watcher) {`
`67`		`- // error intentionally ignored`
`68`		`- await this.watcher.update();`
`69`		`- }`
	`67`	`+ if (this.watcher && this.autoNotifyWatcher) {`
	`68`	`+ // error intentionally ignored`
	`69`	`+ await this.watcher.update();`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`return ruleRemoved;`
`@@ -89,11 +89,11 @@ export class InternalEnforcer extends CoreEnforcer {`
`89`	`89`	`throw e;`
`90`	`90`	`}`
`91`	`91`	`}`
	`92`	`+ }`
`92`	`93`
`93`		`- if (this.watcher) {`
`94`		`- // error intentionally ignored`
`95`		`- await this.watcher.update();`
`96`		`- }`
	`94`	`+ if (this.watcher && this.autoNotifyWatcher) {`
	`95`	`+ // error intentionally ignored`
	`96`	`+ await this.watcher.update();`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`return ruleRemoved;`