feat: implement csv parser

Zxilly · Zxilly · commit f2ddaab9223c · 2021-08-18T15:51:33.000+08:00
This helps to reduce the volume

Signed-off-by: Zxilly &lt;zhouxinyu1001@gmail.com&gt;
diff --git a/package.json b/package.json
@@ -54,7 +54,6 @@
   },
   "peerDependencies": {
     "picomatch": "^2.2.3",
-    "csv-parse": "^4.15.3",
     "buffer": "^6.0.3"
   },
   "dependencies": {
diff --git a/src/util/util.ts b/src/util/util.ts
@@ -15,7 +15,6 @@
 // escapeAssertion escapes the dots in the assertion,
 // because the expression evaluation doesn't support such variable names.
 
-import parse from 'csv-parse/lib/sync';
 import { RoleManager } from '../rbac';
 
 function escapeAssertion(s: string): string {
@@ -157,11 +156,66 @@ function policyArrayToString(policy: string[]): string {
 }
 
 function policyStringToArray(policy: string): string[][] {
-  return parse(policy, {
-    delimiter: ',',
-    skip_empty_lines: true,
-    trim: true,
-  });
+  const endCommaRe = /,$/;
+  const quotaWrapperRe = /^".*"$/;
+
+  const lines: string[] = policy.split(/\r?\n/);
+  const arrays: string[][] = [];
+
+  for (let line of lines) {
+    const commentLabel = line.indexOf('#');
+    if (commentLabel !== -1) {
+      line = line.substr(0, commentLabel);
+    }
+
+    line = line.trim();
+
+    if (endCommaRe.test(line)) {
+      throw new Error('The csv standard does not allow a comma at the end of a sentence');
+    }
+
+    const slices = line.split(',');
+    let tokens: string[] = [];
+
+    for (let slice of slices) {
+      slice = slice.trim();
+
+      // Remove parcel quotes
+      if (quotaWrapperRe.test(slice)) {
+        slice = slice.substr(1, slice.length - 2);
+      }
+
+      if (slice.includes('""')) {
+        // "" Escape processing
+        const quotaSequence: number[] = [];
+
+        let pos = slice.indexOf('"');
+        while (pos !== -1) {
+          quotaSequence.push(pos);
+          pos = slice.indexOf('"', pos + 1);
+        }
+
+        if (quotaSequence.length % 2 !== 0) {
+          throw new Error('Number of quotation marks does not match');
+        }
+
+        for (let i = 0; i < quotaSequence.length; ) {
+          if (quotaSequence[i] !== quotaSequence[i + 1] - 1) {
+            throw new Error(`Unescaped " at ${line}`);
+          }
+          i += 2;
+        }
+
+        slice = slice.replace(/""/g, '"');
+      }
+
+      tokens.push(slice);
+    }
+
+    arrays.push(deepCopy(tokens));
+    tokens = [];
+  }
+  return arrays;
 }
 
 function isRoleManagerSync(rm: RoleManager): boolean {
diff --git a/test/util.test.ts b/test/util.test.ts
@@ -161,7 +161,8 @@ test('test getEvalValue', () => {
 });
 
 test('test policyStringToArray', () => {
-  expect(util.policyStringToArray('p,alice,data1,read')).toEqual([['p', 'alice', 'data1', 'read']]);
+  expect(util.policyStringToArray('p,alice,data1,read#testtest')).toEqual([['p', 'alice', 'data1', 'read']]);
+  expect(util.policyStringToArray('p,ali""ce,data1,read')).toEqual([['p', 'ali"ce', 'data1', 'read']]);
   expect(util.policyStringToArray(`"p","alice","data1","read"`)).toEqual([['p', 'alice', 'data1', 'read']]);
   expect(util.policyStringToArray(`"p"," alice","data1 ","read"`)).toEqual([['p', ' alice', 'data1 ', 'read']]);
   expect(util.policyStringToArray(`p,alice,data1,read\np,bob,data1,write`)).toEqual([
