BUG24946076: Fix table comment SQL generation

amitab · amitab · commit 366ee07764f7 · 2016-10-29T16:23:36.000+05:30
This patch fixes the table comment SQL generation. Quotes were not added around
the comment which gave rise to this error.

Modifed tests to check this.
diff --git a/lib/mysqlx/statement.py b/lib/mysqlx/statement.py
@@ -955,7 +955,7 @@ def _get_table_opts(self):
         if self._collation:
             options.append("DEFAULT COLLATE = {collation}")
         if self._comment:
-            options.append("COMMENT = {comment}")
+            options.append("COMMENT = '{comment}'")
 
         table_opts = ",".join(options)
         return table_opts.format(inc=self._auto_inc, charset=self._charset,
diff --git a/tests/test_mysqlx_crud.py b/tests/test_mysqlx_crud.py
@@ -256,7 +256,8 @@ def test_create_table(self):
         language = self.schema.create_table(table_a) \
             .add_column(mysqlx.ColumnDef('language_id', mysqlx.ColumnType.INT) \
                 .primary().auto_increment().unsigned().not_null()) \
-            .set_initial_auto_increment(12).execute()
+            .set_initial_auto_increment(12) \
+            .set_comment("Table Comment test").execute()
 
         self.assertTrue(language.exists_in_database())
         self.assertEqual(12,
@@ -265,6 +266,12 @@ def test_create_table(self):
                 'FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = "{0}" AND '
                 'TABLE_NAME = "{1}"'.format(self.schema.name, table_a)) \
             .execute().fetch_all()[0][0])
+        self.assertEqual("Table Comment test",
+            self.node_session.sql(
+                'SELECT TABLE_COMMENT FROM INFORMATION_SCHEMA.TABLES '
+                'WHERE TABLE_SCHEMA = "{0}" '
+                'AND TABLE_NAME = "{1}"'.format(self.schema.name, table_a)) \
+            .execute().fetch_all()[0][0])
 
         # Create table with index and foreign keys
         film = self.schema.create_table(table_b) \
