BUG24946101: Fix inline foreign key SQL generation.

amitab · amitab · commit ae0ad82210c9 · 2016-10-29T16:24:01.000+05:30
This patch fixes the inline foreign key reference SQL generation. A
non-existent variable name was used in place of the reference table
name which gave rise to this issue.

Tests cannot be verified because according to MySQL documentation:

MySQL parses but ignores "inline REFERENCES specifications" (as defined
in the SQL standard) where the references are defined as part of the
column specification. MySQL accepts REFERENCES clauses only when specified
as part of a separate FOREIGN KEY specification.
diff --git a/lib/mysqlx/statement.py b/lib/mysqlx/statement.py
@@ -1269,7 +1269,7 @@ def _col_definition(self):
             defn = "{0} UNIQUE KEY".format(defn)
         if self._ref_table and self._ref_fields:
             ref_table = quote_multipart_identifier(parse_table_name(
-                self._default_schema, name))
+                self._default_schema, self._ref_table))
             defn = "{0} REFERENCES {1} ({2})".format(defn, ref_table,
                 ",".join(self._ref_fields))
 
diff --git a/tests/test_mysqlx_crud.py b/tests/test_mysqlx_crud.py
@@ -284,7 +284,7 @@ def test_create_table(self):
             .add_column(mysqlx.ColumnDef('release_year',
                 mysqlx.ColumnType.YEAR, 4)) \
             .add_column(mysqlx.ColumnDef('language_id', mysqlx.ColumnType.INT) \
-                .unsigned().not_null()) \
+                .unsigned().not_null().foreign_key(table_a, 'language_id')) \
             .add_column(mysqlx.ColumnDef('original_language_id',
                 mysqlx.ColumnType.INT).unsigned())\
             .add_column(mysqlx.ColumnDef('rental_duration',
