Skip to content

Commit ae2903c

Browse files
ShMcKShMcK
committed
use mocks for unit tests
1 parent 7e47db2 commit ae2903c

File tree

14 files changed

+83
-36
lines changed

14 files changed

+83
-36
lines changed

‎lib/__mocks__/editor.js

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/__mocks__/editor.js.map

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/modules/dir/index.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/modules/dir/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
"repository": "https://github.com/coderoad/core-coderoad",
2626
"scripts": {
2727
"compile": "tsc",
28-
"test": "jest"
28+
"test": "jest",
29+
"mocks": "tsc -p ./src/__mocks__"
2930
},
3031
"dependencies": {
3132
"atom-plugin-command-line": "1.0.2",

‎src/__mocks__/editor/index.js

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/__mocks__/editor/index.js.map

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/__mocks__/editor/index.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
/**
2+
* Pass in a configuration object to the mock
3+
*/
4+
export const editor = {
5+
name: 'editorName',
6+
directory: () => './path/to/dir',
7+
};

‎src/__mocks__/tsconfig.json

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
{
2+
"compilerOptions": {
3+
"target": "ES5",
4+
"module": "commonjs",
5+
"declaration": false,
6+
"noImplicitAny": false,
7+
"removeComments": true,
8+
"jsx": "react",
9+
"experimentalDecorators": true,
10+
"emitDecoratorMetadata": true,
11+
"sourceMap": true,
12+
"moduleResolution": "node",
13+
"strictNullChecks": true
14+
},
15+
"filesGlob": [
16+
"*.ts",
17+
"**/*.ts",
18+
"*.tsx",
19+
"**/*.tsx"
20+
],
21+
"files": [
22+
"editor/index.ts"
23+
]
24+
}

‎src/components/Start/Start.test.tsx

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,32 @@
11
/// <reference path="../../typings/globals/jest/index.d.ts" />
2+
/// <reference path="../../typings/globals/react/index.d.ts" />
3+
/// <reference path="../../typings/globals/react-redux/index.d.ts" />
4+
/// <reference path="../../typings/globals/react-test-renderer/index.d.ts" />
25

36
import * as React from 'react';
47
import * as renderer from 'react-test-renderer';
58

6-
import Start from './index';
7-
import { Provider } from 'react-redux';
9+
// import Start from './index';
10+
// import { Provider } from 'react-redux';
811

912

10-
import '../../__tests__/mocks';
11-
import mockStore from '../../__tests__/mocks/store';
13+
// import '../../__tests__/mocks';
14+
// import mockStore from '../../__tests__/mocks/store';
1215

13-
describe('<Start />', () => {
16+
xdescribe('<Start />', () => {
1417

15-
it('renders <Welcome /> if checks pass', () => {
16-
const store = mockStore({
17-
checks: {
18-
passed: false
19-
}
20-
});
21-
const tree = renderer.create(
22-
<Provider store={store}>
23-
<Start />
24-
</Provider>
25-
).toJSON();
26-
expect(tree).toMatchSnapshot();
18+
xit('renders <Welcome /> if checks pass', () => {
19+
// const store = mockStore({
20+
// checks: {
21+
// passed: false
22+
// }
23+
// });
24+
// const tree = renderer.create(
25+
// <Provider store={store}>
26+
// <Start />
27+
// </Provider>
28+
// ).toJSON();
29+
// expect(tree).toMatchSnapshot();
2730
});
2831

2932
// xit('renders <Checks /> if check fails', () => {

‎src/modules/dir/reducer.test.ts

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,16 @@
1-
/// <reference path="../../typings/globals/jest/index.d.ts" />
21
/// <reference path="../../typings/common/global.d.ts" />
2+
/// <reference path="../../typings/globals/jest/index.d.ts" />
3+
/// <reference path="../../typings/globals/node/index.d.ts" />
34

5+
jest.setMock('../../index', require('../../__mocks__/editor/index.js'));
46
import dir from './index';
5-
import {atomPath} from '../../__tests__/mocks/atom';
67

78
describe('dir reducer', () => {
89

9-
afterEach(() => {
10-
global.atom = null;
11-
});
12-
13-
it('should return the project directory in Atom', () => {
14-
const pathToDir = './path/to/dir';
15-
global.atom = atomPath(pathToDir);
16-
expect(dir('')).toBe(pathToDir);
17-
});
18-
19-
it('should throw an error if no project directory is found', () => {
20-
expect(() => dir('')).toThrowError(/No project directory/);
10+
it('should return the project directory from the editor', () => {
11+
const directory = './path/to/dir';
12+
// directory() => './path/to/dir' is default
13+
expect(dir('')).toBe(directory);
2114
});
2215

23-
});
16+
});

‎src/modules/editor/reducer.test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
/// <reference path="../../typings/globals/jest/index.d.ts" />
22

3+
jest.setMock('../../index', require('../../__mocks__/editor/index.js'));
34
import reducer from './reducer';
45
import * as types from './types';
56

67
describe('editor reducer', () => {
78

89
it('does nothing if action types do not match', () => {
910
const action = { type: 'unknown' };
10-
expect(reducer(undefined, action)).toBe('atom');
11+
// name: 'editorName' is default
12+
expect(reducer(undefined, action)).toBe('editorName');
1113
});
1214

1315
});

‎src/typings/index.d.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
/// <reference path="common/global.d.ts" />
55
/// <reference path="common/index.d.ts" />
66
/// <reference path="common/package-json.d.ts" />
7+
/// <reference path="editor/index.d.ts" />
78
/// <reference path="globals/atom/custom.d.ts" />
89
/// <reference path="globals/atom/index.d.ts" />
910
/// <reference path="globals/core-js/index.d.ts" />
@@ -16,6 +17,7 @@
1617
/// <reference path="globals/mixto/index.d.ts" />
1718
/// <reference path="globals/node-file-exists/index.d.ts" />
1819
/// <reference path="globals/node/index.d.ts" />
20+
/// <reference path="globals/proxyquire/index.d.ts" />
1921
/// <reference path="globals/react-addons-shallow-compare/index.d.ts" />
2022
/// <reference path="globals/react-addons-test-utils/index.d.ts" />
2123
/// <reference path="globals/react-dom/index.d.ts" />
@@ -36,4 +38,3 @@
3638
/// <reference path="globals/text-buffer/index.d.ts" />
3739
/// <reference path="tests/index.d.ts" />
3840
/// <reference path="tutorial/index.d.ts" />
39-
/// <reference path="editor/index.d.ts" />

‎tsconfig.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
"src/typings/globals/node-file-exists/index.d.ts",
5555
"src/typings/globals/node/index.d.ts",
5656
"src/typings/globals/pathwatcher/index.d.ts",
57+
"src/typings/globals/proxyquire/index.d.ts",
5758
"src/typings/globals/q/index.d.ts",
5859
"src/typings/globals/react-addons-shallow-compare/index.d.ts",
5960
"src/typings/globals/react-addons-test-utils/index.d.ts",
@@ -78,6 +79,7 @@
7879
"src/typings/tests/index.d.ts",
7980
"src/typings/tests/validation.d.ts",
8081
"src/typings/tutorial/index.d.ts",
82+
"src/__mocks__/editor/index.ts",
8183
"src/actions.ts",
8284
"src/components/Common/Markdown/formatText.ts",
8385
"src/components/Common/Markdown/syntax-highlighter.ts",

0 commit comments

Comments
 (0)