Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

fix: emit CInput events from inside a CInputGroup #499

Merged
merged 2 commits into from
Dec 22, 2021
Merged

fix: emit CInput events from inside a CInputGroup #499

merged 2 commits into from
Dec 22, 2021

Conversation

lianulloa
Copy link
Contributor

Description

I pass down the listeners of cinput components using the on option of the data object

Motivation and Context

it fixes issue: #292

How Has This Been Tested?

I tested my changes using yarn storybook and listening for the keypress event on the first event
of the With left and right addons story of CInput

All unit test also where run before pushing my changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: e5a5b91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 11, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/CJtVh8FDZjsGq2jPGdPd6FQwaCZJ
✅ Preview: https://chakra-ui-vue-git-fork-lianulloa-fix-input-group-292-chakra-ui.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 11, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e5a5b91:

Sandbox Source
Chakra UI Vue (0.X) Starter Template Configuration
chakra-ui-nuxt-demo Configuration

codebender828
codebender828 approved these changes Dec 22, 2021
View reviewed changes
Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lianulloa ❤️

@codebender828 codebender828 merged commit c4307d6 into chakra-ui:develop Dec 22, 2021
@codebender828 codebender828 mentioned this pull request Jan 19, 2022
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codebender828 codebender828 codebender828 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lianulloa @codebender828