Show the title on item and user pages.

Dan Hersam · Dan Hersam · commit be77c7cd06c1 · 2016-01-21T11:36:30.000-05:00
Would be nice to avoid duplicating the 'Vue.js HN Clone' string, but I
didn't find a clean way.
diff --git a/src/components/ItemView.vue b/src/components/ItemView.vue
@@ -42,14 +42,16 @@ export default {
 
   route: {
     data ({ to }) {
-      return store.fetchItem(to.params.id).then(item => ({
-        item,
-        // the final resolved data can further contain Promises
-        comments: store.fetchItems(item.kids),
-        pollOptions: item.type === 'poll'
-          ? store.fetchItems(item.parts)
-          : null
-      }))
+      return store.fetchItem(to.params.id).then(item => {
+        document.title = item.title + ' | Vue.js HN Clone'
+        return {
+          item,
+          // the final resolved data can further contain Promises
+          comments: store.fetchItems(item.kids),
+          pollOptions: item.type === 'poll'
+            ? store.fetchItems(item.parts)
+            : null
+        }})
     }
   },
 
diff --git a/src/components/NewsView.vue b/src/components/NewsView.vue
@@ -50,6 +50,7 @@ export default {
       //    the entire object, because we don't want to update the page before
       //    the items are fetched.
       const page = +to.params.page
+      document.title = 'Vue.js HN Clone'
       return store.fetchItemsByPage(page).then(items => ({
         page,
         items
diff --git a/src/components/UserView.vue b/src/components/UserView.vue
@@ -35,6 +35,7 @@ export default {
     data ({ to }) {
       // Promise sugar syntax: return an object that contains Promise fields.
       // http://router.vuejs.org/en/pipeline/data.html#promise-sugar
+      document.title = 'Profile: ' + to.params.id + ' | Vue.js HN Clone'
       return {
         user: store.fetchUser(to.params.id)
       }

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ export default {`
`35`	`35`	`data ({ to }) {`
`36`	`36`	`// Promise sugar syntax: return an object that contains Promise fields.`
`37`	`37`	`// http://router.vuejs.org/en/pipeline/data.html#promise-sugar`
	`38`	`+ document.title = 'Profile: ' + to.params.id + ' \| Vue.js HN Clone'`
`38`	`39`	`return {`
`39`	`40`	`user: store.fetchUser(to.params.id)`
`40`	`41`	`}`