Only use Entry ID<->index maps if necessary #141
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1716e1 to
09ab391
Compare
|
This pull request introduces 1 alert when merging 09ab391 into 8ca8a8c - view on LGTM.com new alerts:
|
In the common case, Entry IDs and indices are both contiguous and start from 0, so these maps are just the identity function. ID->index conversion is on the hot path for drawing Timeline and the boxing/unboxing and map lookup can be relatively costly, so avoid it when possible.
09ab391 to
eb0d1ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the common case, Entry IDs and indices are both contiguous and
start from 0, so these maps are just the identity function. ID->index
conversion is on the hot path for drawing Timeline and the
boxing/unboxing and map lookup can be relatively costly, so avoid it
when possible.