Pull #16829: align ubuntu image version ubuntu-22.04 -> ubuntu-24.04
#16829
Conversation
Note : -> Note: ubuntu-22.04 -> ubuntu-24.04
…ubuntu-24.04`
01e2b45 to
f5043cc
Compare
|
its kind of the same and used to its might worth a try |
azure-pipelines.yml
Outdated
| # moved back to Travis till we find a way to keep secrets in azure | ||
| # ensure that all modules are used in no exception configs | ||
| # 'verify-no-exception-configs': | ||
| # image: 'ubuntu-24.04' | ||
| # cmd: "./.ci/validation.sh verify-no-exception-configs" | ||
| # skipCache: true | ||
| # needXmlstarlet: true | ||
|
|
There was a problem hiding this comment.
Thanks! Yes, I would suggest extracting this into a dedicated issue (#16835), as the codebase should exclusively contain living (active) code—not dead and clunky, overhead (boilerplate) like this.
Currently, this represents a technical debt item that needs to be addressed later.
Storing such issues in a dedicated tracker improves cohesion and aligns with the SOC (Separation of Concerns) principle we follow.
There was a problem hiding this comment.
“SOC” can also be interpreted as: this change is not related in any way to updating the Ubuntu version, and certainly doesn’t belong hidden in the same commit/pull request.
Again, please revert this change.
There was a problem hiding this comment.
this is moved to semaphore actually
checkstyle/.semaphore/semaphore.yml
Lines 39 to 42 in 720de88
There was a problem hiding this comment.
no need to move to Travis , let is sit in semaphore.
to make it more transparent for why we did change, we can make separate commit in this PR and remove it in separate commit with message "infra: verify-no-exception-configs is in semaphore ci"
There was a problem hiding this comment.
Yes, we can remove in a second commit.
There was a problem hiding this comment.
@pankratz76 , please just do second commit, to preserve quick and brief reason of removal
There was a problem hiding this comment.
“SOC” can also be interpreted as: this change is not related in any way to updating the Ubuntu version, and certainly doesn’t belong hidden in the same commit/pull request.
you are perfectly right. Obey SOC in commits and PR´s is clearly not my strength.
…ubuntu-24.04`
f5043cc to
3d58796
Compare
…ubuntu-24.04`
3d58796 to
5c99d3b
Compare
|
thanks for the seamless merge, my good friend |
…ubuntu-24.04`
…ubuntu-24.04`
Pull #16829: align ubuntu image version
ubuntu-22.04->ubuntu-24.0410
vs.
15