-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Pull #5351: fixed RequireThisCheck and catch variable handling #5351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
From travis
@romani Why are we checking our input files? Should I just exclude the file as it is a replica of a regression case? |
This plugin should not validate any test resource files. Please review plugin properties to exclude or point plugin to only required classes. |
Pitest is also joining in, though I'm not sure why. |
Code coverage should be fixed. |
Codecov Report
@@ Coverage Diff @@
## master #5351 +/- ##
======================================
Coverage 100% 100%
======================================
Files 296 296
Lines 16189 16199 +10
Branches 3698 3699 +1
======================================
+ Hits 16189 16199 +10
Continue to review full report at Codecov.
|
Rebased. |
Identified at #5307 (comment)
Catch variables are seen in the scope of the try block instead of the catch block.
Easy printout of frame tree with this changes: rnveach@aad8b03#diff-6b1f89f1bde0470d4bd42580d1aa8bfb
Regression: http://rveach.no-ip.org/checkstyle/regression/reports/143/
http://rveach.no-ip.org/checkstyle/regression/reports/143/spring-framework/index.html#A1