Fix escaped char pattern in AvoidEscapedUnicodeCharactersCheck #9314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strkkk
added a commit
to strkkk/checkstyle
that referenced
this pull request
Feb 20, 2021
…CharactersCheck
559c606 to
17fdba3
Compare
|
Github, generate report |
strkkk
commented
Feb 20, 2021
src/main/java/com/puppycrawl/tools/checkstyle/checks/AvoidEscapedUnicodeCharactersCheck.java
Show resolved
Hide resolved
strkkk
added a commit
to strkkk/checkstyle
that referenced
this pull request
Feb 20, 2021
…CharactersCheck
17fdba3 to
f5b9257
Compare
strkkk
commented
Feb 20, 2021
| + "(00[0-1][0-9A-Fa-f]" | ||
| + "|00[8-9][0-9A-Fa-f]" | ||
| private static final Pattern UNICODE_CONTROL = Pattern.compile("\\\\u+" | ||
| + "(00[0189][0-9A-Fa-f]" |
…CharactersCheck
f5b9257 to
c2699f2
Compare
pbludov
approved these changes
Feb 23, 2021
|
Github, generate report |
|
GitHub, generate report |
|
Report generation job failed on phase , step . |
|
Openjdk report failed by timeout (job was interrupted after 6 hours), but for other reps looks ok. |
romani
approved these changes
Feb 28, 2021
src/main/java/com/puppycrawl/tools/checkstyle/checks/AvoidEscapedUnicodeCharactersCheck.java
Show resolved
Hide resolved
romani
approved these changes
Mar 3, 2021
SGanguly1999
pushed a commit
to SGanguly1999/checkstyle
that referenced
this pull request
Mar 10, 2021
…CharactersCheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AvoidEscapedUnicodeCharactersCheck pattern for escaped chars is a bit incorrect.
According to JLS char 'u' can be repeated many times, and it is still valid escape.
Note: pattern for whitespace escapes was not updated - it is causing sonar violation that require big refactoring of regex and tests.
Diff Regression config: https://gist.githubusercontent.com/strkkk/31749e0743553a606f69fdfc6670d780/raw/2031b8f52d40c522c5cd8c343ff2c8af476082d7/confg.xml
Diff Regression projects: https://gist.githubusercontent.com/strkkk/29c0f3a0ce06a681afdf8d3c417a4b30/raw/f2771cee1ba63f0236377c2b55b77a2fb1fe45e0/small_projects
Report label: only jdk9