False positives for google_checks when using switch expression in lambda #16949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…switch expression in lambdaك
827139e to
43cd3db
Compare
|
@Abdelrhmansersawy , ping. |
Pankraz76
suggested changes
Apr 30, 2025
Comment on lines
+88
to
+97
| // Check for assignment context (from PR #16418) | ||
| if (TokenUtil.isOfType(grandParent, TokenTypes.ASSIGN)) { | ||
| indentLevel = new IndentLevel(indentLevel, | ||
| getIndentCheck().getLineWrappingIndentation()); | ||
| } | ||
| // Check for lambda context | ||
| else if (TokenUtil.isOfType(grandParent, TokenTypes.LAMBDA)) { | ||
| indentLevel = new IndentLevel(indentLevel, | ||
| getIndentCheck().getLineWrappingIndentation()); | ||
| } |
There was a problem hiding this comment.
Suggested change
| // Check for assignment context (from PR #16418) | |
| if (TokenUtil.isOfType(grandParent, TokenTypes.ASSIGN)) { | |
| indentLevel = new IndentLevel(indentLevel, | |
| getIndentCheck().getLineWrappingIndentation()); | |
| } | |
| // Check for lambda context | |
| else if (TokenUtil.isOfType(grandParent, TokenTypes.LAMBDA)) { | |
| indentLevel = new IndentLevel(indentLevel, | |
| getIndentCheck().getLineWrappingIndentation()); | |
| } | |
| // Check for assignment and lambda context (from PR #16418) | |
| if (TokenUtil.isOfType(grandParent, TokenTypes.ASSIGN) || TokenUtil.isOfType(grandParent, TokenTypes.LAMBDA)) { | |
| indentLevel = new IndentLevel(indentLevel, | |
| getIndentCheck().getLineWrappingIndentation()); | |
| } |
avoid dry if possible
I’ve stopped working on this PR because there is another PR#16721 that addresses a different false-positive issue, which also happens to resolve this one. What’s your opinion on continuing to solve this issue separately, or should we rely on the open PRs since they’ve made significant progress and only need a few more steps to be completed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #16762