Issue #17000: AvoidOutdatedUsage: Use modern Java collections API (toList() instead of collect(Collectors.toList()))
#17012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cbdb2f to
50f3cb2
Compare
|
How to fix this please? The checkers seems to work but the test is not parsed properly when doing the wip: 
|
50f3cb2 to
7d459bb
Compare
|
wip |
Pankraz76
commented
May 4, 2025
| // Test other Collector methods | ||
| Collectors.toCollection(ArrayList::new); // ok, modern API | ||
| // FIXME: but was : [22, 23, 26, 27, 28, 35] | ||
| // Foo.toList(); // ok, as custom |
There was a problem hiding this comment.
No we are not java types aware, no class path details. All we have are strings in AST. https://checkstyle.org/writingchecks.html#Limitations
can we fix this overloading issue then? We only should exclude class specific. @romani
There was a problem hiding this comment.
No types available, we can not distinguish overloaded methods.
We don't know hierarchy of types.
All this limitations makes any implementation to be very error prone.
There was a problem hiding this comment.
yes thats right. Maybe then go like lombok ? This always worked for my and better to have it and not miss it. We can tell as it is.
Just check out codebase its capable of so we are example for what its good for.
in the land of the blind, the one-eyed man is king.
263e748 to
a02264b
Compare
|
aa73234 to
83091b9
Compare
…ections API (toList() instead of collect(Collectors.toList()))
83091b9 to
29520ad
Compare
|
wip #16774 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #17000:
AvoidOutdatedUsage: Use modern Java collections API (toList() instead of collect(Collectors.toList()))