fix: retry-after node tests (getsentry#2781)

kamilogorek · web-flow · commit 18db20101a8c · 2020-07-28T15:07:47.000+02:00
diff --git a/packages/node/src/transports/base.ts b/packages/node/src/transports/base.ts
@@ -111,7 +111,7 @@ export abstract class BaseTransport implements Transport {
                * https://nodejs.org/api/http.html#http_message_headers
                */
               let retryAfterHeader = res.headers ? res.headers['retry-after'] : '';
-              retryAfterHeader = Array.isArray(retryAfterHeader) ? retryAfterHeader[0] : retryAfterHeader;
+              retryAfterHeader = (Array.isArray(retryAfterHeader) ? retryAfterHeader[0] : retryAfterHeader) as string;
               this._disabledUntil = new Date(now + parseRetryAfterHeader(now, retryAfterHeader));
               logger.warn(`Too many requests, backing off till: ${this._disabledUntil}`);
             }
diff --git a/packages/node/test/transports/http.test.ts b/packages/node/test/transports/http.test.ts
@@ -87,11 +87,11 @@ describe('HTTPTransport', () => {
     }
   });
 
-  test('back-off using Retry-After header', async () => {
+  test('back-off using retry-after header', async () => {
     const retryAfterSeconds = 10;
     mockReturnCode = 429;
     mockHeaders = {
-      'Retry-After': retryAfterSeconds,
+      'retry-after': retryAfterSeconds,
     };
     const transport = createTransport({ dsn });
 
diff --git a/packages/node/test/transports/https.test.ts b/packages/node/test/transports/https.test.ts
@@ -93,11 +93,11 @@ describe('HTTPSTransport', () => {
     }
   });
 
-  test('back-off using Retry-After header', async () => {
+  test('back-off using retry-after header', async () => {
     const retryAfterSeconds = 10;
     mockReturnCode = 429;
     mockHeaders = {
-      'Retry-After': retryAfterSeconds,
+      'retry-after': retryAfterSeconds,
     };
     const transport = createTransport({ dsn });
 

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ export abstract class BaseTransport implements Transport {`
`111`	`111`	`* https://nodejs.org/api/http.html#http_message_headers`
`112`	`112`	`*/`
`113`	`113`	`let retryAfterHeader = res.headers ? res.headers['retry-after'] : '';`
`114`		`- retryAfterHeader = Array.isArray(retryAfterHeader) ? retryAfterHeader[0] : retryAfterHeader;`
	`114`	`+ retryAfterHeader = (Array.isArray(retryAfterHeader) ? retryAfterHeader[0] : retryAfterHeader) as string;`
`115`	`115`	`this._disabledUntil = new Date(now + parseRetryAfterHeader(now, retryAfterHeader));`
`116`	`116`	logger.warn(`Too many requests, backing off till: ${this._disabledUntil}`);
`117`	`117`	`}`