Skip to content

Commit de4156f

Browse files
committed
Deprecation notice of method which is only used for old deprecated options, which should have been removed in 2.x but are still available now, and will finally be removed in 3.1
Also corrected some silly grammar :D
1 parent 4fe4628 commit de4156f

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

lib/triagens/ArangoDb/Handler.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ protected function getConnectionOption($optionName)
6868
*
6969
* @param mixed $options - $options might be a boolean sanitize value, or an array of options, with or without a '_sanitize' key.
7070
*
71+
* @deprecated To be removed in a future version (probably even in some 3.x version). It's used up until now because of usage of old deprecated options, which will be removed in 3.1.
7172
* @return array - array of options
7273
*/
7374
protected function getCursorOptions($options)
@@ -109,7 +110,7 @@ protected function json_encode_wrapper($body)
109110
}
110111

111112

112-
//todo: (@frankmayer) check if refactoring a bit more if it makes sense...
113+
//todo: (@frankmayer) check if refactoring a bit more makes sense...
113114
/**
114115
* Helper function that validates and includes an old single method parameter setting into the parameters array given.
115116
* This is only for keeping backwards-compatibility where methods had for example a parameter which was called 'policy' and
@@ -147,7 +148,7 @@ protected function validateAndIncludeOldSingleParameterInParams($options, $param
147148
}
148149

149150

150-
//todo: (@frankmayer) check if refactoring a bit more if it makes sense...
151+
//todo: (@frankmayer) check if refactoring a bit more makes sense...
151152
/**
152153
* Helper function that runs through the options given and includes them into the parameters array given.
153154
* Only options that are set in $includeArray will be included.
@@ -176,7 +177,7 @@ protected function includeOptionsInParams($options, $params, array $includeArray
176177
}
177178

178179

179-
//todo: (@frankmayer) check if refactoring a bit more if it makes sense...
180+
//todo: (@frankmayer) check if refactoring a bit more makes sense...
180181
/**
181182
* Helper function that runs through the options given and includes them into the parameters array given.
182183
* Only options that are set in $includeArray will be included.

0 commit comments

Comments
 (0)