From a9da0a1c8fb84a6622b375efbfc5293e0616ba9e Mon Sep 17 00:00:00 2001 From: Lucas Holmquist Date: Wed, 3 May 2023 09:36:21 -0400 Subject: [PATCH 1/2] feat!: remove node 12 and node 14 Node 12 has been EOL since the end of April 2022 and Node 14 just became EOL at the end of April 2023 Signed-off-by: Lucas Holmquist --- .github/workflows/nodejs-ci-action.yml | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nodejs-ci-action.yml b/.github/workflows/nodejs-ci-action.yml index 57b91bc5..0eb50f75 100644 --- a/.github/workflows/nodejs-ci-action.yml +++ b/.github/workflows/nodejs-ci-action.yml @@ -15,7 +15,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [12.x, 14.x, 16.x, 18.x] + node-version: [16.x, 18.x] steps: - uses: actions/checkout@v2 diff --git a/package.json b/package.json index 6fa6ef95..50db3b23 100644 --- a/package.json +++ b/package.json @@ -158,6 +158,6 @@ }, "types": "./dist/index.d.ts", "engines": { - "node": ">=12 <=20.0.0" + "node": ">=16 <=20.0.0" } } From 79edf38e72a737857abbd334a6af0c86596615a0 Mon Sep 17 00:00:00 2001 From: Lucas Holmquist Date: Wed, 3 May 2023 09:58:53 -0400 Subject: [PATCH 2/2] squash: . Signed-off-by: Lucas Holmquist --- .github/workflows/nodejs-ci-action.yml | 2 +- package-lock.json | 2 +- test/integration/parser_test.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nodejs-ci-action.yml b/.github/workflows/nodejs-ci-action.yml index 0eb50f75..e28ce874 100644 --- a/.github/workflows/nodejs-ci-action.yml +++ b/.github/workflows/nodejs-ci-action.yml @@ -15,7 +15,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [16.x, 18.x] + node-version: [16.x, 18.x, 20.x] steps: - uses: actions/checkout@v2 diff --git a/package-lock.json b/package-lock.json index 364ae41c..af9acab1 100644 --- a/package-lock.json +++ b/package-lock.json @@ -53,7 +53,7 @@ "webpack-cli": "^4.10.0" }, "engines": { - "node": ">=12 <=20.0.0" + "node": ">=16 <=20.0.0" } }, "node_modules/@ampproject/remapping": { diff --git a/test/integration/parser_test.ts b/test/integration/parser_test.ts index aa86983b..5be19b3e 100644 --- a/test/integration/parser_test.ts +++ b/test/integration/parser_test.ts @@ -56,7 +56,7 @@ describe("JSON Event Format Parser", () => { const parser = new Parser(); // TODO: Should the parser catch the SyntaxError and re-throw a ValidationError? - expect(parser.parse.bind(parser, payload)).to.throw(SyntaxError, "Unexpected token g in JSON at position 1"); + expect(parser.parse.bind(parser, payload)).to.throw(SyntaxError); }); it("Accepts a string as valid JSON", () => {