Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudevents/sdk-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: cloudevents/sdk-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feat/proto-support
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 7 files changed
  • 1 contributor

Commits on Oct 19, 2022

  1. deps: add protobuf dependency 

    Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
    @xSAVIKx
    xSAVIKx committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    1e69fa3 View commit details
    Browse the repository at this point in the history

  2. deps: add protobuf and grpcio-tools to dev dependencies. 

    we're gonna use grpcio-tools over raw `protoc` to compile python protos

Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
    @xSAVIKx
    xSAVIKx committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    e332e23 View commit details
    Browse the repository at this point in the history

  3. chore: Check in cloudevents.proto from the cloudevents-spec 

    See https://github.com/cloudevents/spec/blob/main/cloudevents/formats/cloudevents.proto for an up-to-date version of the format.

Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
    @xSAVIKx
    xSAVIKx committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    c930e59 View commit details
    Browse the repository at this point in the history

  4. chore: generate proto stubs from the spec. 

    We're using the following command to generate protos using `grpcio-tools` package. The command should be run from the repo root.

```
python -m grpc_tools.protoc -I.\cloudevents\proto\ --python_out=.\cloudevents\proto  .\cloudevents\proto\cloudevents.proto
```

Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
    @xSAVIKx
    xSAVIKx committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    53005c6 View commit details
    Browse the repository at this point in the history

  5. chore: generate proto typeshed stubs. 

    We're using the following command to generate protos and proto type stubs using `grpcio-tools` package. The command should be run from the repo root.

```
python -m grpc_tools.protoc -I.\cloudevents\proto\ --python_out=.\cloudevents\proto --pyi_out=.\cloudevents\proto  .\cloudevents\proto\cloudevents.proto
```

Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
    @xSAVIKx
    xSAVIKx committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    05bb6df View commit details
    Browse the repository at this point in the history

  6. chore: Export proto-generated entries. 

    Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
    @xSAVIKx
    xSAVIKx committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    5932e6e View commit details
    Browse the repository at this point in the history
Loading