Skip to content

is_binary should check more than just ce-specversion #95

Closed
@cumason123

Description

@cumason123

Expected Behavior

from cloudevents.sdk.converters.binary import NewBinaryHTTPCloudEventConverter
cnvtr = NewBinaryHTTPCloudEventConverter()
assert not cnvtr.can_read({"ce-specversion": "1.0"})

Actual Behavior

cnvtr.can_read({"ce-specversion": "1.0"})

will return true because it only checks for ce-specversion and not other required versions.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions