-
Notifications
You must be signed in to change notification settings - Fork 58
Drop EOL Python 3.8 support #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe is a good idea to add:
python_requires=">=3.9"
to setup.py
Read on it a little bit. I'd rather not specify it. The package can be used with 3.8 and I believe even 3.7 it's just we don't support them officially anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Python 3.8 has reached EOL more than a year ago. Dropping support while other tooling is not supporting is anymore as well