Skip to content

Error on the return value of CloudinaryLabs\CloudinaryLaravel\CloudinaryAdapter::readStream() #128

New issue
New issue
Closed
#140
Closed
Error on the return value of CloudinaryLabs\CloudinaryLaravel\CloudinaryAdapter::readStream()#128
#140
Labels
bugSomething isn't working
@AndikanGabriel

Description

@AndikanGabriel
AndikanGabriel
opened on Sep 6, 2024

The readStream method of a storage driver is likely expected to return a resource type, but in this package, it is set to bool.

cloudinary-laravel/src/CloudinaryAdapter.php

Line 291 in 434bb1f

public function readStream(string $path): bool

Upon inspecting its return type, it appears that a boolean value is not returned.

cloudinary-laravel/src/CloudinaryAdapter.php

Lines 291 to 296 in 434bb1f

public function readStream(string $path): bool
{
$resource = (array)$this->adminApi()->asset($this->preparePublicId($path));
return fopen($resource['secure_url'], 'rb');
}

I’m not sure if a fix is in the pipeline.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions