diff --git a/changelog.md b/changelog.md index 04755ec5..ab789807 100644 --- a/changelog.md +++ b/changelog.md @@ -1,3 +1,9 @@ +v6.3.2 - 06/06/22 +========== + +- fix: if --runtimeVerison must be explicitly specified if building for a different runtime +- Update baseurl for electron mirror + v6.3.1 - 05/06/22 ========== diff --git a/lib/runtimePaths.js b/lib/runtimePaths.js index 7c88d258..e2200094 100644 --- a/lib/runtimePaths.js +++ b/lib/runtimePaths.js @@ -5,7 +5,7 @@ let semver = require("semver"); let NODE_MIRROR = process.env.NVM_NODEJS_ORG_MIRROR || "https://nodejs.org/dist"; let IOJS_MIRROR = process.env.NVM_IOJS_ORG_MIRROR || "https://iojs.org/dist"; -let ELECTRON_MIRROR = process.env.ELECTRON_MIRROR || "https://atom.io/download/atom-shell"; +let ELECTRON_MIRROR = process.env.ELECTRON_MIRROR || "https://artifacts.electronjs.org/headers/dist"; let runtimePaths = { node: function (targetOptions) { diff --git a/lib/targetOptions.js b/lib/targetOptions.js index 593c876b..5dc8c822 100644 --- a/lib/targetOptions.js +++ b/lib/targetOptions.js @@ -35,7 +35,11 @@ Object.defineProperties(TargetOptions.prototype, { }, runtimeVersion: { get: function () { - return this.options.runtimeVersion || environment.runtimeVersion; + if (this.runtime != environment.runtime && !this.options.runtimeVersion) { + throw new Error(`Missing runtimeVersion. It must be specified when specifying the runtime`) + } else { + return this.options.runtimeVersion || environment.runtimeVersion; + } } } }); diff --git a/package.json b/package.json index 22d45fe2..49efaab1 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "boost" ], "main": "lib", - "version": "6.3.1", + "version": "6.3.2", "author": "Gábor Mező aka unbornchikken", "repository": { "type": "git",