From 2321d3bd4ee343d14dda105d6e4499c8e2ae9473 Mon Sep 17 00:00:00 2001 From: Julian Waller Date: Mon, 6 Jun 2022 19:21:35 +0100 Subject: [PATCH 1/3] fix: error if runtime is specified but not runtimeVersion --- lib/targetOptions.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/targetOptions.js b/lib/targetOptions.js index 593c876b..5dc8c822 100644 --- a/lib/targetOptions.js +++ b/lib/targetOptions.js @@ -35,7 +35,11 @@ Object.defineProperties(TargetOptions.prototype, { }, runtimeVersion: { get: function () { - return this.options.runtimeVersion || environment.runtimeVersion; + if (this.runtime != environment.runtime && !this.options.runtimeVersion) { + throw new Error(`Missing runtimeVersion. It must be specified when specifying the runtime`) + } else { + return this.options.runtimeVersion || environment.runtimeVersion; + } } } }); From 78d817fbecf51cf2dde9a9047883bdfbe900c524 Mon Sep 17 00:00:00 2001 From: ci7lus <7887955+ci7lus@users.noreply.github.com> Date: Tue, 7 Jun 2022 03:23:27 +0900 Subject: [PATCH 2/3] chore: update baseurl for electron mirror (#279) --- lib/runtimePaths.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/runtimePaths.js b/lib/runtimePaths.js index 7c88d258..e2200094 100644 --- a/lib/runtimePaths.js +++ b/lib/runtimePaths.js @@ -5,7 +5,7 @@ let semver = require("semver"); let NODE_MIRROR = process.env.NVM_NODEJS_ORG_MIRROR || "https://nodejs.org/dist"; let IOJS_MIRROR = process.env.NVM_IOJS_ORG_MIRROR || "https://iojs.org/dist"; -let ELECTRON_MIRROR = process.env.ELECTRON_MIRROR || "https://atom.io/download/atom-shell"; +let ELECTRON_MIRROR = process.env.ELECTRON_MIRROR || "https://artifacts.electronjs.org/headers/dist"; let runtimePaths = { node: function (targetOptions) { From 2e69605cce296be758bd8e7eabaa7a6e10675924 Mon Sep 17 00:00:00 2001 From: Julian Waller Date: Mon, 6 Jun 2022 19:25:36 +0100 Subject: [PATCH 3/3] v6.3.2 --- changelog.md | 6 ++++++ package.json | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/changelog.md b/changelog.md index 04755ec5..ab789807 100644 --- a/changelog.md +++ b/changelog.md @@ -1,3 +1,9 @@ +v6.3.2 - 06/06/22 +========== + +- fix: if --runtimeVerison must be explicitly specified if building for a different runtime +- Update baseurl for electron mirror + v6.3.1 - 05/06/22 ========== diff --git a/package.json b/package.json index 22d45fe2..49efaab1 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "boost" ], "main": "lib", - "version": "6.3.1", + "version": "6.3.2", "author": "Gábor Mező aka unbornchikken", "repository": { "type": "git",