From e0354d4bab63f1b9c856311a222d96170b0c4632 Mon Sep 17 00:00:00 2001 From: Felix Rieseberg Date: Tue, 9 Oct 2018 13:49:14 -0700 Subject: [PATCH 1/2] :wrench: Support Electron v4 --- lib/es6/runtimePaths.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/es6/runtimePaths.js b/lib/es6/runtimePaths.js index ec1d0e5a..3bd20c83 100644 --- a/lib/es6/runtimePaths.js +++ b/lib/es6/runtimePaths.js @@ -79,7 +79,7 @@ let runtimePaths = { name: "node.lib" }], tarPath: "node" + "-v" + targetOptions.runtimeVersion + ".tar.gz", - headerOnly: false + headerOnly: semver.gte(targetOptions.runtimeVersion, '>=4.0.0-alpha') }; }, get: function (targetOptions) { From 063e434902b4b32172641ec9b7fda411b46e836a Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Tue, 20 Nov 2018 10:47:03 -0800 Subject: [PATCH 2/2] Update runtimePaths.js --- lib/es6/runtimePaths.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/es6/runtimePaths.js b/lib/es6/runtimePaths.js index 3bd20c83..7c88d258 100644 --- a/lib/es6/runtimePaths.js +++ b/lib/es6/runtimePaths.js @@ -79,7 +79,7 @@ let runtimePaths = { name: "node.lib" }], tarPath: "node" + "-v" + targetOptions.runtimeVersion + ".tar.gz", - headerOnly: semver.gte(targetOptions.runtimeVersion, '>=4.0.0-alpha') + headerOnly: semver.gte(targetOptions.runtimeVersion, '4.0.0-alpha') }; }, get: function (targetOptions) { @@ -95,4 +95,4 @@ let runtimePaths = { } }; -module.exports = runtimePaths; \ No newline at end of file +module.exports = runtimePaths;