Skip to content

Commit e002575

Browse files
authored
Merge pull request element-hq#2513 from vector-im/rav/no_bundle_components_css
Don't include two copies of the CSS in the tarball
2 parents e564d34 + e1919c5 commit e002575

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1+
/build
12
/cert.pem
23
/karma-reports
34
/key.pem
45
/lib
56
/node_modules
67
/packages/
78
/vector/bundle.*
8-
/vector/components.css
99
/vector/emojione/
1010
/vector/config.json
1111
/vector/olm.js

package.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"reskindex": "reskindex -h src/header",
1515
"build:emojione": "cpx \"node_modules/emojione/assets/svg/*\" vector/emojione/svg/",
1616
"build:modernizr": "modernizr -c .modernizr.json -d src/vector/modernizr.js",
17-
"build:css": "catw \"src/skins/vector/css/**/*.css\" -o vector/components.css --no-watch",
17+
"build:css": "mkdirp build && catw \"src/skins/vector/css/**/*.css\" -o build/components.css --no-watch",
1818
"build:compile": "babel --source-maps -d lib src",
1919
"build:bundle": "NODE_ENV=production webpack -p lib/vector/index.js vector/bundle.js",
2020
"build:bundle:dev": "webpack --optimize-occurence-order lib/vector/index.js vector/bundle.js",
@@ -25,12 +25,12 @@
2525
"start:emojione": "cpx \"node_modules/emojione/assets/svg/*\" vector/emojione/svg/ -w",
2626
"start:js": "webpack -w src/vector/index.js vector/bundle.js",
2727
"start:js:prod": "NODE_ENV=production webpack -w src/vector/index.js vector/bundle.js",
28-
"start:skins:css": "catw \"src/skins/vector/css/**/*.css\" -o vector/components.css",
28+
"start:skins:css": "mkdirp build && catw \"src/skins/vector/css/**/*.css\" -o build/components.css",
2929
"start:staticfiles": "cpx -Lwv node_modules/olm/olm.js vector/",
3030
"//cache": "Note the -c 1 below due to https://code.google.com/p/chromium/issues/detail?id=508270",
3131
"start": "node scripts/babelcheck.js && parallelshell \"npm run start:staticfiles\" \"npm run start:emojione\" \"npm run start:js\" \"npm run start:skins:css\" \"http-server -c 1 vector\"",
3232
"start:prod": "parallelshell \"npm run start:staticfiles\" \"npm run start:emojione\" \"npm run start:js:prod\" \"npm run start:skins:css\" \"http-server -c 1 vector\"",
33-
"clean": "rimraf lib vector/olm.js vector/bundle.css vector/bundle.js vector/bundle.js.map vector/webpack.css* vector/emojione",
33+
"clean": "rimraf build lib vector/olm.js vector/bundle.css vector/bundle.js vector/bundle.js.map vector/webpack.css* vector/emojione",
3434
"prepublish": "npm run build:css && npm run build:compile",
3535
"test": "karma start --single-run=true --autoWatch=false --browsers PhantomJS --colors=false",
3636
"test:multi": "karma start"
@@ -92,6 +92,7 @@
9292
"karma-phantomjs-launcher": "^1.0.0",
9393
"karma-sourcemap-loader": "^0.3.7",
9494
"karma-webpack": "^1.7.0",
95+
"mkdirp": "^0.5.1",
9596
"mocha": "^2.4.5",
9697
"parallelshell": "^1.2.0",
9798
"phantomjs-prebuilt": "^2.1.7",

src/vector/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ limitations under the License.
2929
require('babel-polyfill');
3030

3131
// CSS requires: just putting them here for now as CSS is going to be
32-
// refactored soon anyway
33-
require('../../vector/components.css');
32+
// refactored "soon" anyway
33+
require('../build/components.css');
3434
require('gemini-scrollbar/gemini-scrollbar.css');
3535
require('gfm.css/gfm.css');
3636
require('highlight.js/styles/github.css');

0 commit comments

Comments
 (0)